[Android] Prompt with infobar on filename conflict

chrome/browser/android/download_overwrite_infobar_delegate.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/android/download_overwrite_infobar_delegate.h"
+
+#include "base/memory/scoped_ptr.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/infobars/infobar_service.h"
+#include "chrome/browser/ui/android/infobars/download_overwrite_infobar.h"
+#include "chrome/grit/generated_resources.h"
+#include "components/infobars/core/infobar.h"
+#include "content/public/browser/download_item.h"
+#include "content/public/browser/web_contents.h"
+#include "grit/theme_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace chrome {
+namespace android {
+
+// static
+infobars::InfoBar* DownloadOverwriteInfoBarDelegate::Create(

[Ted C, 2014/10/15 00:19:44]

the ordering of the .cc should match exactly the .h (.ie. this came before the
destructor in the header).

[Changwan Ryu, 2014/10/15 22:23:24]

Done.

+    content::DownloadItem* download,
+    const base::FilePath& suggested_path,
+    const FileSelectedCallback& callback) {
+  DCHECK(download);
+  if (!download)
+    return NULL;
+  content::WebContents* web_contents = download->GetWebContents();
+  if (!web_contents)
+    return NULL;
+
+  InfoBarService* infobar_service =
+      InfoBarService::FromWebContents(web_contents);
+
+  DownloadOverwriteInfoBarDelegate* const delegate =
+      new DownloadOverwriteInfoBarDelegate(download, suggested_path, callback);
+  infobars::InfoBar* infobar = DownloadOverwriteInfoBar::CreateInfoBar(
+      scoped_ptr<DownloadOverwriteInfoBarDelegate>(delegate)).release();
+  return infobar_service->AddInfoBar(scoped_ptr<infobars::InfoBar>(infobar));
+}
+
+bool DownloadOverwriteInfoBarDelegate::Accept() {
+  callback_.Run(suggested_path_);
+  return true;
+}
+
+bool DownloadOverwriteInfoBarDelegate::Cancel() {
+  callback_.Run(base::FilePath());
+  return true;
+}
+
+DownloadOverwriteInfoBarDelegate::DownloadOverwriteInfoBarDelegate(
+    content::DownloadItem* download,
+    const base::FilePath& suggested_path,
+    const FileSelectedCallback& callback) :

[Ted C, 2014/10/15 00:19:44]

the : goes on the next line (aligning with the const above)

[Changwan Ryu, 2014/10/15 22:23:24]

Done.

+      pending_id_(download->GetId()),
+      suggested_path_(suggested_path),
+      callback_(callback) {
+}
+
+DownloadOverwriteInfoBarDelegate::~DownloadOverwriteInfoBarDelegate() {
+}
+
+std::string DownloadOverwriteInfoBarDelegate::GetFileName() const {
+  return suggested_path_.BaseName().value();
+}
+
+std::string DownloadOverwriteInfoBarDelegate::GetDirName() const {
+  return suggested_path_.DirName().BaseName().value();
+}
+
+std::string DownloadOverwriteInfoBarDelegate::GetDirFullPath() const {
+  return suggested_path_.DirName().value();
+}
+
+DownloadOverwriteInfoBarDelegate*
+    DownloadOverwriteInfoBarDelegate::AsDownloadOverwriteInfoBarDelegate() {
+  return this;
+}
+
+}  // namespace android
+}  // namespace chrome