chrome/browser/metrics/metrics_log.cc - Issue 58003005: Modify Entity Suggestion support and Add Profile Suggest support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_log.cc

Issue 58003005: Modify Entity Suggestion support and Add Profile Suggest support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed classifications from server Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/search_provider.cc ('K') | « chrome/browser/autocomplete/zero_suggest_provider.cc ('k') | chrome/common/autocomplete_match_type.h » ('j') | chrome/common/metrics/proto/omnibox_event.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_log.cc

diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc

index f286d1f88b781d967654b9af057f895fe301401c..11732c1e559b64597bf51f20ef049027ecfc5322 100644

--- a/chrome/browser/metrics/metrics_log.cc

+++ b/chrome/browser/metrics/metrics_log.cc

@@ -131,6 +131,14 @@ OmniboxEventProto::Suggestion::ResultType AsOmniboxEventResultType(

return OmniboxEventProto::Suggestion::SEARCH_HISTORY;

case AutocompleteMatchType::SEARCH_SUGGEST:

return OmniboxEventProto::Suggestion::SEARCH_SUGGEST;

+ case AutocompleteMatchType::SEARCH_SUGGEST_ENTITY:

+ return OmniboxEventProto::Suggestion::SEARCH_SUGGEST_ENTITY;

+ case AutocompleteMatchType::SEARCH_SUGGEST_INFINITE:

+ return OmniboxEventProto::Suggestion::SEARCH_SUGGEST_INFINITE;

+ case AutocompleteMatchType::SEARCH_SUGGEST_PERSONALIZED:

+ return OmniboxEventProto::Suggestion::SEARCH_SUGGEST_PERSONALIZED;

+ case AutocompleteMatchType::SEARCH_SUGGEST_PROFILE:

+ return OmniboxEventProto::Suggestion::SEARCH_SUGGEST_PROFILE;

case AutocompleteMatchType::SEARCH_OTHER_ENGINE:

return OmniboxEventProto::Suggestion::SEARCH_OTHER_ENGINE;

case AutocompleteMatchType::EXTENSION_APP: