Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: chrome/browser/autocomplete/autocomplete_controller.cc

Issue 58003005: Modify Entity Suggestion support and Add Profile Suggest support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/autocomplete/autocomplete_match.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_controller.cc
diff --git a/chrome/browser/autocomplete/autocomplete_controller.cc b/chrome/browser/autocomplete/autocomplete_controller.cc
index 3be114882258adba385a1dd1167bd989544b87a1..6e578521050bb1acc3bcbb124714353ec2640405 100644
--- a/chrome/browser/autocomplete/autocomplete_controller.cc
+++ b/chrome/browser/autocomplete/autocomplete_controller.cc
@@ -57,6 +57,22 @@ void AutocompleteMatchToAssistedQuery(
*type = 0;
return;
}
+ case AutocompleteMatchType::SEARCH_SUGGEST_ENTITY: {
+ *subtype = 46;
+ return;
+ }
+ case AutocompleteMatchType::SEARCH_SUGGEST_INFINITE: {
+ *subtype = 33;
+ return;
+ }
+ case AutocompleteMatchType::SEARCH_SUGGEST_PERSONALIZED: {
+ *subtype = 35;
+ return;
+ }
+ case AutocompleteMatchType::SEARCH_SUGGEST_PROFILE: {
+ *subtype = 44;
+ return;
+ }
case AutocompleteMatchType::NAVSUGGEST: {
*type = 5;
return;
@@ -127,6 +143,12 @@ bool IsTrivialAutocompletion(const AutocompleteMatch& match) {
match.type == AutocompleteMatchType::SEARCH_OTHER_ENGINE;
}
+// Whether this autocomplete match type supports custom descriptions.
+bool AutocompleteMatchHasCustomDescription(const AutocompleteMatch& match) {
+ return match.type == AutocompleteMatchType::SEARCH_SUGGEST_ENTITY ||
+ match.type == AutocompleteMatchType::SEARCH_SUGGEST_PROFILE;
+}
+
} // namespace
const int AutocompleteController::kNoItemSelected = -1;
@@ -517,6 +539,8 @@ void AutocompleteController::UpdateKeywordDescriptions(
!i->keyword.empty()) ||
(i->provider->type() == AutocompleteProvider::TYPE_SEARCH &&
AutocompleteMatch::IsSearchType(i->type))) {
+ if (AutocompleteMatchHasCustomDescription(*i))
+ continue;
i->description.clear();
i->description_class.clear();
DCHECK(!i->keyword.empty());
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/autocomplete/autocomplete_match.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698