Impelments IfThenElse instruction for ARM and MIPS.

Impelments IfThenElse instruction for ARM and MIPS.

R=fschneider@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29933

[zra, 2013-11-04 23:38:40]

I've just aped the ia32 implementation without thinking deeply about what this
is supposed to do. There might be better sequences on ARM and MIPS. Someone who
knows how this works should suggest better sequences.

[Florian Schneider, 2013-11-05 16:57:52]

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_arm.cc:153: bool IfThenElseInstr::IsSupported()
{
Now that IsSupported is true on all platform, you can remove this function.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_arm.cc:186: // TODO(vegorov): support byte
register constraints in the register allocator.
This TODO is not relevant here.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_arm.cc:212: // Clear upper part of the out
register. We are going to use setcc on it
Update this comment for ARM.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_arm.cc:262: if (ShifterOperand::CanHold(val,
&op)) {
I'd add an AndImmediate macro-instruction for this sequence here.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_mips.cc (right):

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_mips.cc:185: // TODO(vegorov): support byte
register constraints in the register allocator.
Comment not relevant here.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_mips.cc:212: // which is a byte move.
Update comment.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_mips.cc:251: switch (true_condition) {
true_condition can only be EQ or NE here. The other cases must be UNREACHABLE.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_mips.cc:274: if (Utils::IsUint(kImmBits, val))
{
AndImmediate

[zra, 2013-11-05 18:32:13]

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_arm.cc:153: bool IfThenElseInstr::IsSupported()
{
On 2013/11/05 16:57:53, Florian Schneider wrote:
> Now that IsSupported is true on all platform, you can remove this function.

Done.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_arm.cc:186: // TODO(vegorov): support byte
register constraints in the register allocator.
On 2013/11/05 16:57:53, Florian Schneider wrote:
> This TODO is not relevant here.

Done.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_arm.cc:212: // Clear upper part of the out
register. We are going to use setcc on it
On 2013/11/05 16:57:53, Florian Schneider wrote:
> Update this comment for ARM.

Done.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_arm.cc:262: if (ShifterOperand::CanHold(val,
&op)) {
On 2013/11/05 16:57:53, Florian Schneider wrote:
> I'd add an AndImmediate macro-instruction for this sequence here.

Done.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_mips.cc (right):

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_mips.cc:185: // TODO(vegorov): support byte
register constraints in the register allocator.
On 2013/11/05 16:57:53, Florian Schneider wrote:
> Comment not relevant here.

Done.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_mips.cc:212: // which is a byte move.
On 2013/11/05 16:57:53, Florian Schneider wrote:
> Update comment.

Done.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_mips.cc:251: switch (true_condition) {
On 2013/11/05 16:57:53, Florian Schneider wrote:
> true_condition can only be EQ or NE here. The other cases must be UNREACHABLE.

Done.

https://codereview.chromium.org/58003003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_mips.cc:274: if (Utils::IsUint(kImmBits, val))
{
On 2013/11/05 16:57:53, Florian Schneider wrote:
> AndImmediate

Done.

[Florian Schneider, 2013-11-05 19:26:55]

LGTM.

[zra, 2013-11-05 20:45:32]

Committed patchset #3 manually as r29933 (presubmit successful).