chrome/browser/chromeos/fileapi/file_system_backend.cc - Issue 580023003: Rename the drive: scheme with the externalfile: scheme.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/fileapi/file_system_backend.cc

Issue 580023003: Rename the drive: scheme with the externalfile: scheme. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/fileapi/external_file_url_util_unittest.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/fileapi/file_system_backend.cc

diff --git a/chrome/browser/chromeos/fileapi/file_system_backend.cc b/chrome/browser/chromeos/fileapi/file_system_backend.cc

index c029fff108dd770d4638e1a6a5ef510fc53020ad..f9f5ecff083bd0e0821cd277b9df52cd9a4119e9 100644

--- a/chrome/browser/chromeos/fileapi/file_system_backend.cc

+++ b/chrome/browser/chromeos/fileapi/file_system_backend.cc

@@ -181,9 +181,10 @@ bool FileSystemBackend::IsAccessAllowed(

return true;

}

- // Grant access for URL having "drive:" scheme. The URL filesystem:drive:/xxx

- // cannot be parsed directly. The URL is created only by DriveURLRequestJob.

- if (url.origin().scheme() == chrome::kDriveScheme)

+ // Grant access for URL having "externalfile:" scheme. The URL

+ // filesystem:externalfile:/xxx cannot be parsed directly. The URL is created

+ // only by DriveURLRequestJob.

+ if (url.origin().scheme() == chrome::kExternalFileScheme)

return true;

// Check first to make sure this extension has fileBrowserHander permissions.

« no previous file with comments | « chrome/browser/chromeos/fileapi/external_file_url_util_unittest.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »