[Fetch API] Add tests of 304 handling for fetch()

[Fetch API] Add tests of 304 handling for fetch().

This is the same as what xmlhttprequest/cache-override.html checks for XMLHttpRequest. 
See: https://github.com/slightlyoff/ServiceWorker/issues/412

BUG=None
TEST=http/tests/serviceworker/fetch-cache-override.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182322

[horo, 2014-09-18 09:40:03]

Patchset #2 (id:20001) has been deleted

[horo, 2014-09-18 09:40:09]

Patchset #1 (id:1) has been deleted

[horo, 2014-09-18 09:41:07]

horo@chromium.org changed reviewers:
+ nhiroki@chromium.org

[horo, 2014-09-18 09:41:08]

nhiroki@

[horo, 2014-09-18 09:41:21]

nhiroki@
Could you please review this?

[nhiroki, 2014-09-18 10:39:32]

LGTM with nits (I haven't checked test expectations though)

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
File
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js
(right):

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:9:
'Here\'s an other html file.\n';
+4-space indent?

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:35:
'If-Modified-Since override response status must be 304');
(suggestion) 'Status of the request overridden with "If-Modified-Since" must be
304' ?

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:80:
'412');
+4-space indent?

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:87:
'empty');
ditto.

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:169:

nit: There is an empty line.

[nhiroki, 2014-09-18 10:42:34]

FYI:

> This is the same as what xmlhttprequest/cache-override.html checks for
XMLHttpRequest. 
> See: https://codereview.chromium.org/580023002/

Circular reference! :D

[horo, 2014-09-19 04:49:55]

Patchset #2 (id:60001) has been deleted

[horo, 2014-09-19 05:02:31]

Patchset #2 (id:80001) has been deleted

[horo, 2014-09-19 05:06:12]

> > See: https://codereview.chromium.org/580023002/
>
> Circular reference! :D
Fixed.

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
File
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js
(right):

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:9:
'Here\'s an other html file.\n';
On 2014/09/18 10:39:32, nhiroki wrote:
> +4-space indent?

Done.

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:35:
'If-Modified-Since override response status must be 304');
On 2014/09/18 10:39:32, nhiroki wrote:
> (suggestion) 'Status of the request overridden with "If-Modified-Since" must
be
> 304' ?

refined

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:80:
'412');
On 2014/09/18 10:39:32, nhiroki wrote:
> +4-space indent?

Done.

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:87:
'empty');
On 2014/09/18 10:39:32, nhiroki wrote:
> ditto.

Done.

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:169:

On 2014/09/18 10:39:32, nhiroki wrote:
> nit: There is an empty line.

Done.

[horo, 2014-09-19 05:06:13]

> > See: https://codereview.chromium.org/580023002/
>
> Circular reference! :D
Fixed.

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
File
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js
(right):

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:9:
'Here\'s an other html file.\n';
On 2014/09/18 10:39:32, nhiroki wrote:
> +4-space indent?

Done.

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:35:
'If-Modified-Since override response status must be 304');
On 2014/09/18 10:39:32, nhiroki wrote:
> (suggestion) 'Status of the request overridden with "If-Modified-Since" must
be
> 304' ?

refined

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:80:
'412');
On 2014/09/18 10:39:32, nhiroki wrote:
> +4-space indent?

Done.

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:87:
'empty');
On 2014/09/18 10:39:32, nhiroki wrote:
> ditto.

Done.

https://codereview.chromium.org/580023002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-cache-override-worker.js:169:

On 2014/09/18 10:39:32, nhiroki wrote:
> nit: There is an empty line.

Done.

[nhiroki, 2014-09-19 07:15:52]

lgtm 2

[horo, 2014-09-19 12:54:06]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-09-19 12:54:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/580023002/100001

[commit-bot: I haz the power, 2014-09-19 13:00:53]

Committed patchset #2 (id:100001) as 182322