Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: Source/core/rendering/RenderListBox.cpp

Issue 580013002: Support size<4 rendering of listbox <select>. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/platform/mac/fast/forms/select/listbox-appearance-basic-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderListBox.cpp
diff --git a/Source/core/rendering/RenderListBox.cpp b/Source/core/rendering/RenderListBox.cpp
index 5f2807373bf8c0a57abac981db85bfb828403a2c..9bbac7e4fd4f6bd4599b76dbfb2da5e95c1fb7c3 100644
--- a/Source/core/rendering/RenderListBox.cpp
+++ b/Source/core/rendering/RenderListBox.cpp
@@ -64,10 +64,6 @@ namespace blink {
using namespace HTMLNames;
-// The minSize constant was originally defined to render scrollbars correctly.
-// This might vary for different platforms.
-const int minSize = 4;
-
// Default size when the multiple attribute is present but size attribute is absent.
const int defaultSize = 4;
@@ -93,8 +89,8 @@ inline HTMLSelectElement* RenderListBox::selectElement() const
int RenderListBox::size() const
{
int specifiedSize = selectElement()->size();
- if (specifiedSize > 1)
- return max(minSize, specifiedSize);
+ if (specifiedSize >= 1)
+ return specifiedSize;
return defaultSize;
}
« no previous file with comments | « LayoutTests/platform/mac/fast/forms/select/listbox-appearance-basic-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698