Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: LayoutTests/fast/forms/select-clientheight-with-multiple-attr.html

Issue 580013002: Support size<4 rendering of listbox <select>. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/forms/select-clientheight-with-multiple-attr.html
diff --git a/LayoutTests/fast/forms/select-clientheight-with-multiple-attr.html b/LayoutTests/fast/forms/select-clientheight-with-multiple-attr.html
index 7c13b99ec00e910e8679b20dbe9189070cfaded2..6b432e235085fa84a81df4298ff482e4df47e228 100644
--- a/LayoutTests/fast/forms/select-clientheight-with-multiple-attr.html
+++ b/LayoutTests/fast/forms/select-clientheight-with-multiple-attr.html
@@ -47,10 +47,11 @@
shouldBe("clientHeight('sel2')", "clientHeight('sel1')");
shouldBeTrue("getElemById('sel2').setAttribute('size', '5'); clientHeight('sel2') > clientHeight('sel1')");
shouldBe("clientHeight('sel3')", "clientHeight('sel1')");
- shouldBe("getElemById('sel3').setAttribute('size', '2'); clientHeight('sel3')", "clientHeight('sel1')");
+ shouldBeTrue("getElemById('sel3').setAttribute('size', '2'); clientHeight('sel3') < clientHeight('sel1')");
shouldBe("getElemById('sel3').setAttribute('size', '0'); clientHeight('sel3')", "clientHeight('sel1')");
shouldBe("getElemById('sel3').setAttribute('size', ''); clientHeight('sel3')", "clientHeight('sel1')");
- shouldBe("getElemById('sel3').setAttribute('size', '1+ef'); clientHeight('sel3')", "clientHeight('sel1')");
+ // '1+ef' is recognized as 1. This is compatible with IE and Firefox.
+ shouldBeTrue("getElemById('sel3').setAttribute('size', '1+ef'); clientHeight('sel3') < clientHeight('sel1')");
</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698