Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 579973003: Retire obsolete Valgrind supressions ..124156 (Closed)

Created:
6 years, 3 months ago by Eric Willigers
Modified:
6 years, 3 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Retire obsolete Valgrind supressions ..124156 The following supressions are no longer needed: bug_122189 bug_122192 bug_122245a bug_122245b bug_122429 bug_122431 bug_122435a bug_122435b bug_122436 bug_122437 bug_122454 bug_122455 bug_122670 bug_122716 bug_122752a bug_122752b bug_124156 Note: omitting bug 122752 from BUG list as the bug doesn't seem to exist. BUG=122189, 122192, 122245, 122429, 122431, 122435, 122436, 122437, 122454, 122455, 122670, 122716, 124156 R=groby@chromium.org NOTRY=true Committed: https://crrev.com/1d4696a33ce436756ec682e98703b02a7656d7bb Cr-Commit-Position: refs/heads/master@{#295431}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -203 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 4 chunks +0 lines, -203 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Eric Willigers
6 years, 3 months ago (2014-09-18 05:30:00 UTC) #1
groby-ooo-7-16
RSLGTM - did not re-check if suppressions are actually obsolete. Also, feel free to set ...
6 years, 3 months ago (2014-09-18 06:16:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579973003/1
6 years, 3 months ago (2014-09-18 06:25:21 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-18 06:25:23 UTC) #6
groby-ooo-7-16
Sorry - LGTM. At some point, RSLGTM worked :(
6 years, 3 months ago (2014-09-18 06:33:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579973003/20001
6 years, 3 months ago (2014-09-18 07:01:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 77e5e9795daaefb51ffc848cbf6c1e6f63476fbf
6 years, 3 months ago (2014-09-18 07:01:48 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 07:03:13 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d4696a33ce436756ec682e98703b02a7656d7bb
Cr-Commit-Position: refs/heads/master@{#295431}

Powered by Google App Engine
This is Rietveld 408576698