chrome/browser/signin/signin_global_error.cc - Issue 57993006: signin: record http response codes and net errors in OAuth2AccessTokenFetcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_global_error.cc

Issue 57993006: signin: record http response codes and net errors in OAuth2AccessTokenFetcher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/invalidation/ticl_invalidation_service.cc ('k') | chrome/browser/signin/signin_ui_util.cc » ('j') | google_apis/gaia/oauth2_access_token_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/signin_global_error.cc

diff --git a/chrome/browser/signin/signin_global_error.cc b/chrome/browser/signin/signin_global_error.cc

index 3b31038024e0fb844b6464f6bebcb79d37f71dd0..e97c891d27010a92f987fd980db556052500a195 100644

--- a/chrome/browser/signin/signin_global_error.cc

+++ b/chrome/browser/signin/signin_global_error.cc

@@ -166,6 +166,7 @@ std::vector<string16> SigninGlobalError::GetBubbleViewMessages() {

// User credentials are invalid (bad acct, etc).

case GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS:

+ case GoogleServiceAuthError::SERVICE_ERROR:

case GoogleServiceAuthError::ACCOUNT_DELETED:

case GoogleServiceAuthError::ACCOUNT_DISABLED:

messages.push_back(l10n_util::GetStringFUTF16(