signin: record http response codes and net errors in OAuth2AccessTokenFetcher.

google_apis/gaia/oauth2_access_token_fetcher_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A complete set of unit tests for OAuth2AccessTokenFetcher.
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "content/public/test/test_browser_thread_bundle.h"
@@ skipping 32 matching lines @@
     "  \"access_token\": \"at1\","
     "  \"expires_in\": 3600,"
     "  \"token_type\": \"Bearer\""
     "}";
 static const char kTokenResponseNoAccessToken[] =
     "{"
     "  \"expires_in\": 3600,"
     "  \"token_type\": \"Bearer\""
     "}";
 
+static const char kValidFailureTokenResponse[] =
+    "{"
+    "  \"error\": \"invalid_grant\""
+    "}";
+
 class MockUrlFetcherFactory : public ScopedURLFetcherFactory,
                               public URLFetcherFactory {
 public:
   MockUrlFetcherFactory()
       : ScopedURLFetcherFactory(this) {
   }
   virtual ~MockUrlFetcherFactory() {}
 
   MOCK_METHOD4(
       CreateURLFetcher,
@@ skipping 125 matching lines @@
 #define MAYBE_ParseGetAccessTokenResponse DISABLED_ParseGetAccessTokenResponse
 #else
 #define MAYBE_ParseGetAccessTokenResponse ParseGetAccessTokenResponse
 #endif // defined(OS_WIN)
 TEST_F(OAuth2AccessTokenFetcherTest, MAYBE_ParseGetAccessTokenResponse) {
   {  // No body.
     TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
 
     std::string at;
     int expires_in;
-    EXPECT_FALSE(OAuth2AccessTokenFetcher::ParseGetAccessTokenResponse(
+    EXPECT_FALSE(OAuth2AccessTokenFetcher::ParseGetAccessTokenSuccessResponse(
         &url_fetcher, &at, &expires_in));
     EXPECT_TRUE(at.empty());
   }
   {  // Bad json.
     TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
     url_fetcher.SetResponseString("foo");
 
     std::string at;
     int expires_in;
-    EXPECT_FALSE(OAuth2AccessTokenFetcher::ParseGetAccessTokenResponse(
+    EXPECT_FALSE(OAuth2AccessTokenFetcher::ParseGetAccessTokenSuccessResponse(
         &url_fetcher, &at, &expires_in));
     EXPECT_TRUE(at.empty());
   }
   {  // Valid json: access token missing.
     TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
     url_fetcher.SetResponseString(kTokenResponseNoAccessToken);
 
     std::string at;
     int expires_in;
-    EXPECT_FALSE(OAuth2AccessTokenFetcher::ParseGetAccessTokenResponse(
+    EXPECT_FALSE(OAuth2AccessTokenFetcher::ParseGetAccessTokenSuccessResponse(
         &url_fetcher, &at, &expires_in));
     EXPECT_TRUE(at.empty());
   }
   {  // Valid json: all good.
     TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
     url_fetcher.SetResponseString(kValidTokenResponse);
 
     std::string at;
     int expires_in;
-    EXPECT_TRUE(OAuth2AccessTokenFetcher::ParseGetAccessTokenResponse(
+    EXPECT_TRUE(OAuth2AccessTokenFetcher::ParseGetAccessTokenSuccessResponse(
         &url_fetcher, &at, &expires_in));
     EXPECT_EQ("at1", at);
     EXPECT_EQ(3600, expires_in);
   }
-}
+  {  // Valid json: invalid error response.
+     TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
+     url_fetcher.SetResponseString(kTokenResponseNoAccessToken);
+
+     std::string error;
+     EXPECT_FALSE(OAuth2AccessTokenFetcher::ParseGetAccessTokenFailureResponse(
+         &url_fetcher, &error));
+     EXPECT_TRUE(error.empty());
+   }
+   {  // Valid json: error response.
+     TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
+     url_fetcher.SetResponseString(kValidFailureTokenResponse);
+
+     std::string error;
+     EXPECT_TRUE(OAuth2AccessTokenFetcher::ParseGetAccessTokenFailureResponse(
+         &url_fetcher, &error));
+     EXPECT_EQ("invalid_grant", error);
+   }
+}