Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 579923002: Bis: Use SkImage::NewFromGenerator() instead of SkImage::newEncodedData() (Closed)

Created:
6 years, 3 months ago by Rémi Piotaix
Modified:
6 years, 3 months ago
Reviewers:
Justin Novosad, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Bis: Use SkImage::NewFromGenerator() instead of SkImage::newEncodedData() BUG=skia:2948 Committed: https://skia.googlesource.com/skia/+/0d276f71d2cf30f4a282cd4f470084c6b42c6af2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M gm/image.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Rémi Piotaix
PTAL
6 years, 3 months ago (2014-09-17 22:16:43 UTC) #2
Justin Novosad
why?
6 years, 3 months ago (2014-09-18 04:23:12 UTC) #3
Rémi Piotaix
On 2014/09/18 04:23:12, junov wrote: > why? On 2014/09/18 04:23:12, junov wrote: > why? This ...
6 years, 3 months ago (2014-09-18 17:37:00 UTC) #4
Justin Novosad
We want to remove SkImage_Codec? Leaving for reed to review.
6 years, 3 months ago (2014-09-18 17:49:45 UTC) #5
reed1
lgtm
6 years, 3 months ago (2014-09-18 18:45:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579923002/1
6 years, 3 months ago (2014-09-18 18:46:44 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:55:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 0d276f71d2cf30f4a282cd4f470084c6b42c6af2

Powered by Google App Engine
This is Rietveld 408576698