Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 579843002: Copy layer-hoisting related SkPaints (Closed)

Created:
6 years, 3 months ago by robertphillips
Modified:
6 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Copy layer-hoisting related SkPaints This is intended to disconnect the lifetimes of the optimization data, cached layers and replacement objects. Note that the optimization data already makes a copy of the paint in the SkPicture. Additionally the replacement object will probably go away at some point. Committed: https://skia.googlesource.com/skia/+/a0537deca24abc2713e72f61e9cec14bdcc703d0

Patch Set 1 #

Patch Set 2 : Copy layer hoisting related SkPaints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M src/gpu/GrLayerCache.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
robertphillips
6 years, 3 months ago (2014-09-17 19:25:45 UTC) #2
bsalomon
On 2014/09/17 19:25:45, robertphillips wrote: why not tlazy to save heap allocs?
6 years, 3 months ago (2014-09-17 20:06:49 UTC) #3
bsalomon
lgtm
6 years, 3 months ago (2014-09-18 14:42:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579843002/20001
6 years, 3 months ago (2014-09-18 14:54:02 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 15:01:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as a0537deca24abc2713e72f61e9cec14bdcc703d0

Powered by Google App Engine
This is Rietveld 408576698