Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 579773003: Small refactoring in SkImage_Codec (Closed)

Created:
6 years, 3 months ago by Rémi Piotaix
Modified:
6 years, 3 months ago
Reviewers:
Justin Novosad, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M src/image/SkImage_Codec.cpp View 2 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Rémi Piotaix
PTAL
6 years, 3 months ago (2014-09-17 19:14:09 UTC) #2
reed1
Why can't this subclass use lazy images the way we do for the imagegenerate one? ...
6 years, 3 months ago (2014-09-17 19:22:51 UTC) #3
Rémi Piotaix
On 2014/09/17 19:22:51, reed1 wrote: > Why can't this subclass use lazy images the way ...
6 years, 3 months ago (2014-09-17 19:40:45 UTC) #4
reed1
This CL is no worse, so we can wait on potentially refactoring this subclass to ...
6 years, 3 months ago (2014-09-17 19:52:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579773003/1
6 years, 3 months ago (2014-09-17 19:56:37 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 20:05:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 7b433f15de2c69e7b37e163e50ce7984085cdf46

Powered by Google App Engine
This is Rietveld 408576698