Issue 579733003: Revert "Move SkGpuDevice.h to src/gpu"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 579733003: Revert "Move SkGpuDevice.h to src/gpu" (Closed)

Created:
6 years, 3 months ago by borenet

Modified:
6 years, 3 months ago

Reviewers:
bsalomon, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert "Move SkGpuDevice.h to src/gpu" This reverts commit d99bbb61e58e8bd34db3954147ce1c9166fe4637. Causing Chrome canary failures as well as failures of Chrome trybots due to not cleaning up properly after failed DEPS roll attempts. BUG=skia: TBR=bsalomon,reed Committed: https://skia.googlesource.com/skia/+/b0a35f7c5d2c4bfeb601e3ac43f412d202a25292

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -209 lines)			Patch
M	experimental/PdfViewer/pdf_viewer_main.cpp	View	4 chunks	+43 lines, -1 line	0 comments	Download
M	gyp/gpu.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download
A +	include/gpu/SkGpuDevice.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	src/gpu/SkGpuDevice.h	View	1 chunk	+0 lines, -208 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579733003/1

6 years, 3 months ago (2014-09-17 13:04:54 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as b0a35f7c5d2c4bfeb601e3ac43f412d202a25292

6 years, 3 months ago (2014-09-17 13:14:41 UTC) #4

bsalomon

6 years, 3 months ago (2014-09-17 13:22:29 UTC) #5

Message was sent while issue was closed.

On 2014/09/17 13:14:41, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as b0a35f7c5d2c4bfeb601e3ac43f412d202a25292

A blink side fix is about to land that removes the dependency on SkGpuDevice.h.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages