Introduce simplified BooleanToNumber operator.

Introduce simplified BooleanToNumber operator.

R=titzer@chromium.org
TEST=cctest/test-simplified-lowering/LowerBooleanToNumber

Committed: https://code.google.com/p/v8/source/detail?r=24009

[titzer, 2014-09-17 12:01:22]

https://codereview.chromium.org/579723004/diff/1/src/compiler/simplified-oper...
File src/compiler/simplified-operator.cc (right):

https://codereview.chromium.org/579723004/diff/1/src/compiler/simplified-oper...
src/compiler/simplified-operator.cc:68: V(BooleanToNumber,
Operator::kNoProperties, 1)       \
Should be pure. And I think the Number operators should be as well.

https://codereview.chromium.org/579723004/diff/1/test/cctest/compiler/test-si...
File test/cctest/compiler/test-simplified-lowering.cc (right):

https://codereview.chromium.org/579723004/diff/1/test/cctest/compiler/test-si...
test/cctest/compiler/test-simplified-lowering.cc:825:
TEST(LowerBooleanToNumber_tagged_int32) {
Maybe also want to test it being used as tagged, to make sure that you don't get
the boolean, but a tagged number result.

[Michael Starzinger, 2014-09-17 12:43:28]

Addressed comments. PTAL.

https://codereview.chromium.org/579723004/diff/1/src/compiler/simplified-oper...
File src/compiler/simplified-operator.cc (right):

https://codereview.chromium.org/579723004/diff/1/src/compiler/simplified-oper...
src/compiler/simplified-operator.cc:68: V(BooleanToNumber,
Operator::kNoProperties, 1)       \
On 2014/09/17 12:01:22, titzer wrote:
> Should be pure. And I think the Number operators should be as well.

Acknowledged. I agree, please appreciate kPure being added in line 104 further
down ...

https://codereview.chromium.org/579723004/diff/1/src/compiler/simplified-oper...
src/compiler/simplified-operator.cc:104: : SimpleOperator(IrOpcode::k##Name,
Operator::kPure | properties, \
... here.

https://codereview.chromium.org/579723004/diff/1/test/cctest/compiler/test-si...
File test/cctest/compiler/test-simplified-lowering.cc (right):

https://codereview.chromium.org/579723004/diff/1/test/cctest/compiler/test-si...
test/cctest/compiler/test-simplified-lowering.cc:825:
TEST(LowerBooleanToNumber_tagged_int32) {
On 2014/09/17 12:01:22, titzer wrote:
> Maybe also want to test it being used as tagged, to make sure that you don't
get
> the boolean, but a tagged number result.

Done (both kRepBit and kRepTagged used as tagged).

[titzer, 2014-09-17 14:16:05]

lgtm

[Michael Starzinger, 2014-09-17 14:47:38]

Committed patchset #2 (id:20001) manually as 24009 (presubmit successful).