Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 579673002: Check that an img element with src set to a data URI with an invalid mediatype renders

Created:
6 years, 3 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 2 months ago
Reviewers:
hiroshige
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Check that an img element with src set to a data URI with an invalid mediatype renders We have been accepting a data URI with an invalid mediatype. Image test data in Base64 is copied from fast/images/image-load-event-crash.html. Depends on https://codereview.chromium.org/555383003/ R=hiroshige BUG=412479

Patch Set 1 #

Patch Set 2 : Add empty mediatype test #

Total comments: 2

Patch Set 3 : Rebase and addressed #3 #

Messages

Total messages: 12 (5 generated)
tyoshino (SeeGerritForStatus)
Hiroshige, could you please take a look?
6 years, 2 months ago (2014-10-02 03:42:13 UTC) #2
hiroshige
lgtm. https://codereview.chromium.org/579673002/diff/20001/LayoutTests/fast/images/image-from-data-uri-with-invalid-mediatype.html File LayoutTests/fast/images/image-from-data-uri-with-invalid-mediatype.html (right): https://codereview.chromium.org/579673002/diff/20001/LayoutTests/fast/images/image-from-data-uri-with-invalid-mediatype.html#newcode4 LayoutTests/fast/images/image-from-data-uri-with-invalid-mediatype.html:4: top-level type. without a slash and subtype) for ...
6 years, 2 months ago (2014-10-06 08:43:08 UTC) #3
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/579673002/diff/20001/LayoutTests/fast/images/image-from-data-uri-with-invalid-mediatype.html File LayoutTests/fast/images/image-from-data-uri-with-invalid-mediatype.html (right): https://codereview.chromium.org/579673002/diff/20001/LayoutTests/fast/images/image-from-data-uri-with-invalid-mediatype.html#newcode4 LayoutTests/fast/images/image-from-data-uri-with-invalid-mediatype.html:4: top-level type. without a slash and subtype) for backward ...
6 years, 2 months ago (2014-10-16 09:27:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579673002/40001
6 years, 2 months ago (2014-10-16 09:30:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/27269)
6 years, 2 months ago (2014-10-16 11:01:32 UTC) #10
hiroshige
I tested on Mac and the position of the image was shown a little above ...
6 years, 2 months ago (2014-10-17 04:31:19 UTC) #11
tyoshino (SeeGerritForStatus)
6 years, 2 months ago (2014-10-17 04:46:09 UTC) #12
On 2014/10/17 04:31:19, hiroshige wrote:
> I tested on Mac and the position of the image was shown a little above from
the
> expectation of this CL.

I'll investigate

https://storage.googleapis.com/chromium-layout-test-archives/win_blink_rel/32...

Powered by Google App Engine
This is Rietveld 408576698