Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 579663002: Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/file_system_provider (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
satorux1
CC:
chromium-reviews, davemoore+watch_chromium.org, kinuko+fileapi, nhiroki, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/file_system_provider This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Committed: https://crrev.com/0c0930e5a6d6ca2921f6121f20d5de7604af3e5a Cr-Commit-Position: refs/heads/master@{#295224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Some more fixups needed as a result of CL churn today. Hopefully this will be ...
6 years, 3 months ago (2014-09-17 02:24:33 UTC) #2
satorux1
lgtm
6 years, 3 months ago (2014-09-17 03:08:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579663002/1
6 years, 3 months ago (2014-09-17 03:16:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8f9955651e06d9ea647ed51a74831c822d063701
6 years, 3 months ago (2014-09-17 03:50:59 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 03:51:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c0930e5a6d6ca2921f6121f20d5de7604af3e5a
Cr-Commit-Position: refs/heads/master@{#295224}

Powered by Google App Engine
This is Rietveld 408576698