Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 57963005: [Mac] Update the warnings UI for malicious downloads. (Closed)

Created:
7 years, 1 month ago by asanka
Modified:
7 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, benjhayden+dwatch_chromium.org
Visibility:
Public.

Description

[Mac] Update the warnings UI for malicious downloads. When SafeBrowsing detects that a download is malicious, the user is only presented with a 'Dismiss' option. Additional options ('Learn more' and optionally 'Report', if applicable) are available from a context menu. This behavior has been available on the Windows build. This change brings the Mac UI up to parity. XIB Changes (DownloadItem.xib): * Add new controls for malicious downloads: * New GTMWidthBasedTweaker for managing the size of 'Dismiss' button connected to maliciousButtonTweaker: IBOutlet. * New 'Dismiss' push button connected to dismissMaliciousDownload: IBAction. * New disclosure button connected to showContextMenu: IBAction. * Change connection for GTMWidthBasedTweaker containing 'Discard' button to dangerousButtonTweaker: IBOutlet. * Anchor WidthBasedTweakers on the left instead of the right since the code assumes that the tweakers don't shift horizontally when the embedded buttons change size. * Change height of Insecure Download NSBox to match the height of the DownloadItemButton. * Adjust position of buttons for both dangerous and malicious downloads so that they are centered in the download shelf. BUG=235931 TEST=(1) Download something from a URL that is identified by SafeBrowsing as malicious. (2) Check that the download shelf displays a warning indicating that the download was malicious and that it was blocked. There should only be a "Dismiss" button and a disclosure button. (3) Click on the disclosure button. It should display a menu with a 'Learn more' item. Clicking on that item should open the SafeBrowsing help center article. (4) Click on the 'Dismiss' button. The warning should go away. If it was the only download, the shelf should also disappear. (5) Open chrome://downloads. The download should still be here with a 'Recover' option and a 'Remove' option. Original Review URL: https://codereview.chromium.org/40733005/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -69 lines) Patch
M chrome/app/nibs/DownloadItem.xib View 20 chunks +231 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_controller.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_controller.mm View 3 chunks +76 lines, -42 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
asanka
Hi Nico, Could you take a quick look at this one? PS0 is identical to ...
7 years, 1 month ago (2013-11-04 20:17:25 UTC) #1
asanka
On 2013/11/04 20:17:25, asanka wrote: > Hi Nico, > > Could you take a quick ...
7 years, 1 month ago (2013-11-04 20:20:18 UTC) #2
Nico
lgtm stamp
7 years, 1 month ago (2013-11-04 20:21:11 UTC) #3
asanka
On 2013/11/04 20:21:11, Nico wrote: > lgtm stamp Thanks!
7 years, 1 month ago (2013-11-04 20:32:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/57963005/1
7 years, 1 month ago (2013-11-04 20:56:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=93540
7 years, 1 month ago (2013-11-05 01:23:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/57963005/1
7 years, 1 month ago (2013-11-05 02:39:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/57963005/1
7 years, 1 month ago (2013-11-05 03:27:13 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 07:25:32 UTC) #9
Message was sent while issue was closed.
Change committed as 232945

Powered by Google App Engine
This is Rietveld 408576698