Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 57963003: Enforces 10px visibility when dragging between displays (Closed)

Created:
7 years, 1 month ago by varkha
Modified:
7 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enforces 10px visibility when dragging between displays. This scenario is possibly overlooked in https://codereview.chromium.org/21979005. BUG=314696 TEST=ash_unittests --gtest_filter=*WindowDragWithMultiDisplays:*WindowDragWithMultiDisplaysRightToLeft Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233344

Patch Set 1 : Enforces 30% visibility when dragging between displays #

Patch Set 2 : Enforces 10px visibility when dragging between displays #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M ash/wm/dock/docked_window_resizer.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 4 chunks +13 lines, -3 lines 0 comments Download
M ash/wm/window_resizer.cc View 1 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
varkha
oshima@, can you please take a look? I think this is what you wanted originally ...
7 years, 1 month ago (2013-11-04 18:03:00 UTC) #1
varkha
oshima@, I think this matches our discussion yesterday. PTAL.
7 years, 1 month ago (2013-11-05 16:36:02 UTC) #2
oshima
lgtm
7 years, 1 month ago (2013-11-05 22:00:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/57963003/100001
7 years, 1 month ago (2013-11-05 22:18:29 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94257
7 years, 1 month ago (2013-11-06 02:16:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/57963003/100001
7 years, 1 month ago (2013-11-06 02:26:53 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94517
7 years, 1 month ago (2013-11-06 06:07:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/57963003/100001
7 years, 1 month ago (2013-11-06 06:11:33 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94671
7 years, 1 month ago (2013-11-06 10:03:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/57963003/100001
7 years, 1 month ago (2013-11-06 13:31:48 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94919
7 years, 1 month ago (2013-11-06 17:01:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/57963003/100001
7 years, 1 month ago (2013-11-06 19:00:30 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 20:31:08 UTC) #13
Message was sent while issue was closed. 
Change committed as 233344

Powered by Google App Engine
This is Rietveld 408576698