Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 579623003: Upgrade liblouis to 2.6.0. (Closed)

Created:
6 years, 3 months ago by Peter Lundblad
Modified:
6 years, 3 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Upgrade liblouis to 2.6.0. This changes to the new mirror of the third_party library liblouis, necessary because the project moved to github from an svn repository on code.google.com. Since the git mirroring infrastructure doesn't support excluding parts of the tree, this means adding some GPL files and some files without license headers. The whitelist in tools/checklicenses/checklicenses.py has been extended as needed. One braille table (Hindi computer braille) is not available in liblouis and has been removed. A follow-up CL will add support for new braille tables added in this release. BUG=341951 R=dtseng@chromium.org, phajdan.jr@chromium.org Committed: https://crrev.com/88aa7765109f2d8bca73dd793a6109236189fde0 Cr-Commit-Position: refs/heads/master@{#295679}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Simplify whitelist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -5863 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/braille_table_test.extjs View 1 chunk +1 line, -1 line 0 comments Download
M third_party/liblouis/LICENSE View 1 chunk +1 line, -1 line 0 comments Download
M third_party/liblouis/README.chromium View 2 chunks +6 lines, -10 lines 0 comments Download
M third_party/liblouis/liblouis_nacl.gyp View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/liblouis/overrides/liblouis/compileTranslationTable.c View 1 chunk +0 lines, -5221 lines 0 comments Download
M third_party/liblouis/overrides/liblouis/config.h View 1 chunk +4 lines, -16 lines 0 comments Download
M third_party/liblouis/overrides/liblouis/liblouis.h View 3 chunks +75 lines, -38 lines 0 comments Download
D third_party/liblouis/overrides/tables/braille-patterns.cti View 1 chunk +0 lines, -287 lines 0 comments Download
D third_party/liblouis/overrides/tables/da.ctb View 1 chunk +0 lines, -280 lines 0 comments Download
M third_party/liblouis/tables.json View 2 chunks +1 line, -7 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Peter Lundblad
@phajdan.jr: for the license check script. @dtseng: for the rest.
6 years, 3 months ago (2014-09-17 14:47:11 UTC) #1
Paweł Hajdan Jr.
https://codereview.chromium.org/579623003/diff/1/tools/checklicenses/checklicenses.py File tools/checklicenses/checklicenses.py (right): https://codereview.chromium.org/579623003/diff/1/tools/checklicenses/checklicenses.py#newcode239 tools/checklicenses/checklicenses.py:239: 'third_party/liblouis/src/build-aux': [ Just one suppression for third_party/liblouis would be ...
6 years, 3 months ago (2014-09-17 20:23:27 UTC) #2
David Tseng
lgtm
6 years, 3 months ago (2014-09-18 01:52:16 UTC) #3
Peter Lundblad
phajdan.jr@chromium.org writes: > > https://codereview.chromium.org/579623003/diff/1/tools/checklicenses/checklicenses.py > File tools/checklicenses/checklicenses.py (right): > > https://codereview.chromium.org/579623003/diff/1/tools/checklicenses/checklicenses.py#newcode239 > tools/checklicenses/checklicenses.py:239: > ...
6 years, 3 months ago (2014-09-18 10:15:31 UTC) #4
Paweł Hajdan Jr.
LGTM
6 years, 3 months ago (2014-09-18 23:51:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579623003/20001
6 years, 3 months ago (2014-09-19 07:37:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f115f56dbbff374d2aae4d609877ff12424eff2f
6 years, 3 months ago (2014-09-19 08:34:33 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 08:35:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88aa7765109f2d8bca73dd793a6109236189fde0
Cr-Commit-Position: refs/heads/master@{#295679}

Powered by Google App Engine
This is Rietveld 408576698