Cancel AppCache manifest requests on any SSL error.

Cancel AppCache manifest requests on any SSL error.

BUG=414026

[palmer, 2014-09-17 00:26:36]

palmer@chromium.org changed reviewers:
+ michaeln@chromium.org

[palmer, 2014-09-17 00:26:36]

michaeln: This seems like it should do the right thing, but I am finding when I
test it that AppCacheUpdateJob::URLFetcher::OnSSLCertificateError never gets
called (the other event handlers, like
AppCacheUpdateJob::URLFetcher::OnReadCompleted, *do* get called). My local HTTPS
server definitely has certificate problems, so I don't know why they don't get
triggered. Any clues?

[michaeln, 2014-09-17 03:06:27]

On 2014/09/17 00:26:36, Chromium Palmer wrote:
> michaeln: This seems like it should do the right thing, but I am finding when
I
> test it that AppCacheUpdateJob::URLFetcher::OnSSLCertificateError never gets
> called (the other event handlers, like
> AppCacheUpdateJob::URLFetcher::OnReadCompleted, *do* get called). My local
HTTPS
> server definitely has certificate problems, so I don't know why they don't get
> triggered. Any clues?

The default impl of URLRequest::Delegate::OnSSLCertificateError does what your
override is doing, cancel's the request. There's another issue open about
allowing sites with untrusted certs to be cached? I was surprised to see this
bug about resources with bad certs getting into the cache.
https://code.google.com/p/chromium/issues/detail?id=78859

> Any clues?

Not really? Put a breakpoint in URLRequestHttpJob::OnStartCompleted.

[michaeln, 2014-10-10 22:14:57]

see https://codereview.chromium.org/645123003/