Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 579583005: Downloads: Add an alt + c key to clear all downloads on chrome://downloads. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
asanka, Dan Beam
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Downloads: Add an alt + c key to clear all downloads on chrome://downloads. Committed: https://crrev.com/cd82b473e9485d401a6c6651c51ece3c795ab188 Cr-Commit-Position: refs/heads/master@{#295382}

Patch Set 1 #

Patch Set 2 : with comment #

Total comments: 13

Patch Set 3 : address dbeam comments #

Total comments: 4

Patch Set 4 : nit #

Patch Set 5 : keyEvt #

Patch Set 6 : moar nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/resources/downloads/downloads.js View 1 2 3 4 5 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (4 generated)
Lei Zhang
6 years, 3 months ago (2014-09-17 01:25:26 UTC) #2
asanka
Code lgtm, but I'm wondering if the problem being address could be solved by adding ...
6 years, 3 months ago (2014-09-17 19:20:33 UTC) #3
Dan Beam
> Do we need a nanny prompt to intervene before destroying all of history based ...
6 years, 3 months ago (2014-09-17 20:48:59 UTC) #4
Lei Zhang
On 2014/09/17 19:20:33, asanka wrote: > Code lgtm, but I'm wondering if the problem being ...
6 years, 3 months ago (2014-09-17 20:58:59 UTC) #5
Lei Zhang
https://codereview.chromium.org/579583005/diff/20001/chrome/browser/resources/downloads/downloads.js File chrome/browser/resources/downloads/downloads.js (right): https://codereview.chromium.org/579583005/diff/20001/chrome/browser/resources/downloads/downloads.js#newcode112 chrome/browser/resources/downloads/downloads.js:112: window.addEventListener('keydown', this.onKeyDown, true); On 2014/09/17 20:48:58, Dan Beam wrote: ...
6 years, 3 months ago (2014-09-17 21:31:15 UTC) #6
Dan Beam
https://codereview.chromium.org/579583005/diff/20001/chrome/browser/resources/downloads/downloads.js File chrome/browser/resources/downloads/downloads.js (right): https://codereview.chromium.org/579583005/diff/20001/chrome/browser/resources/downloads/downloads.js#newcode280 chrome/browser/resources/downloads/downloads.js:280: return; On 2014/09/17 21:31:15, Lei Zhang wrote: > On ...
6 years, 3 months ago (2014-09-17 21:39:29 UTC) #7
Lei Zhang
On 2014/09/17 21:39:29, Dan Beam wrote: > https://codereview.chromium.org/579583005/diff/20001/chrome/browser/resources/downloads/downloads.js > File chrome/browser/resources/downloads/downloads.js (right): > > https://codereview.chromium.org/579583005/diff/20001/chrome/browser/resources/downloads/downloads.js#newcode280 ...
6 years, 3 months ago (2014-09-17 21:41:24 UTC) #8
Dan Beam
https://codereview.chromium.org/579583005/diff/40001/chrome/browser/resources/downloads/downloads.js File chrome/browser/resources/downloads/downloads.js (right): https://codereview.chromium.org/579583005/diff/40001/chrome/browser/resources/downloads/downloads.js#newcode112 chrome/browser/resources/downloads/downloads.js:112: window.addEventListener('keydown', this.onKeyDown_); nit: onKeyDown_.bind(this) is a better "in case" ...
6 years, 3 months ago (2014-09-17 21:41:42 UTC) #9
Dan Beam
lgtm w/nits
6 years, 3 months ago (2014-09-17 21:42:37 UTC) #10
Lei Zhang
https://codereview.chromium.org/579583005/diff/40001/chrome/browser/resources/downloads/downloads.js File chrome/browser/resources/downloads/downloads.js (right): https://codereview.chromium.org/579583005/diff/40001/chrome/browser/resources/downloads/downloads.js#newcode112 chrome/browser/resources/downloads/downloads.js:112: window.addEventListener('keydown', this.onKeyDown_); On 2014/09/17 21:41:41, Dan Beam wrote: > ...
6 years, 3 months ago (2014-09-17 21:50:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579583005/100001
6 years, 3 months ago (2014-09-17 21:51:50 UTC) #13
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-17 23:52:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579583005/100001
6 years, 3 months ago (2014-09-17 23:55:51 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 6d34441eb850d01f7291f63ed143b4788038ef3f
6 years, 3 months ago (2014-09-18 00:27:44 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 00:28:21 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/cd82b473e9485d401a6c6651c51ece3c795ab188
Cr-Commit-Position: refs/heads/master@{#295382}

Powered by Google App Engine
This is Rietveld 408576698