Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 579583003: Revert of Remote Assistance on Chrome OS Part I - Aura Desktop Capturer (Closed)

Created:
6 years, 3 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 3 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Remote Assistance on Chrome OS Part I - Aura Desktop Capturer (patchset #11 id:220001 of https://codereview.chromium.org/543243003/) Reason for revert: This patch appears to cause a Chrome OS bot to break. http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=71945 Original issue's description: > Remote Assistance on Chrome OS - Aura Desktop Capturer > > This CL implements a WebRTC Desktop Capturer that captures from > the Aura Shell root window. > > The capturer is used by the It2MeHost on Chrome OS. > |DesktopCaptureDeviceAura| cannot be re-used in our scenario > because is timer-driven as opposed to caller driven, which is > required by WebRTC. > > The current implementation uses the layer API > > desktop_window_->layer()->RequestCopyOfOutput(request.Pass()) > > to request the layer and its subtree to be rendered to a > |SkiaBitmap|. It then copies the pixels to a WebRTC |DesktopFrame|. > > BUG=411530 > > Committed: https://crrev.com/278b065b519617b1e9231bd53e6502706d20787c > Cr-Commit-Position: refs/heads/master@{#295187} TBR=sergeyu@chromium.org,dcaiafa@chromium.org,darin@chromium.org,wez@chromium.org,jamescook@chromium.org,reed@google.com,danakj@chromium.org,sky@chromium.org,kelvinp@chromium.org NOTREECHECKS=true NOTRY=true BUG=411530 Committed: https://crrev.com/365c61ee0448affac494e59101d58c286a3812f2 Cr-Commit-Position: refs/heads/master@{#295196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -388 lines) Patch
M remoting/host/DEPS View 2 chunks +0 lines, -3 lines 0 comments Download
D remoting/host/chromeos/aura_desktop_capturer.h View 1 chunk +0 lines, -53 lines 0 comments Download
D remoting/host/chromeos/aura_desktop_capturer.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D remoting/host/chromeos/aura_desktop_capturer_unittest.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M remoting/remoting_host.gypi View 10 chunks +64 lines, -118 lines 0 comments Download
M remoting/remoting_test.gypi View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
acolwell GONE FROM CHROMIUM
Created Revert of Remote Assistance on Chrome OS Part I - Aura Desktop Capturer
6 years, 3 months ago (2014-09-17 00:43:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579583003/1
6 years, 3 months ago (2014-09-17 00:46:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as eeb5d064c46ddf84f02d819985d12bcadfec8461
6 years, 3 months ago (2014-09-17 00:52:42 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 00:53:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/365c61ee0448affac494e59101d58c286a3812f2
Cr-Commit-Position: refs/heads/master@{#295196}

Powered by Google App Engine
This is Rietveld 408576698