Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest_delegate.h

Issue 579563002: Find working in app_shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest_delegate.h
diff --git a/extensions/browser/guest_view/web_view/web_view_guest_delegate.h b/extensions/browser/guest_view/web_view/web_view_guest_delegate.h
index f2f087d25fdf7d9eabc8d028df3063af38e71472..f8a2dbf65060cb61901db730ca9fff34cfcde036 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest_delegate.h
+++ b/extensions/browser/guest_view/web_view/web_view_guest_delegate.h
@@ -7,10 +7,6 @@
#include "extensions/browser/guest_view/guest_view_base.h"
-namespace blink {
-struct WebFindOptions;
-} // nanespace blink
-
namespace content {
class RenderViewHost;
class WebContents;
@@ -19,7 +15,6 @@ class WebContents;
namespace extensions {
class WebViewGuest;
-class WebViewInternalFindFunction;
namespace api {
namespace web_view_internal {
@@ -31,26 +26,11 @@ struct ContextMenuItem;
// A delegate class of WebViewGuest that are not a part of chrome.
class WebViewGuestDelegate {
public :
- explicit WebViewGuestDelegate(WebViewGuest* web_view_guest);
- virtual ~WebViewGuestDelegate();
+ virtual ~WebViewGuestDelegate() {}
typedef std::vector<linked_ptr<api::web_view_internal::ContextMenuItem> >
MenuItemVector;
- // Begin or continue a find request.
- virtual void Find(
- const base::string16& search_text,
- const blink::WebFindOptions& options,
- WebViewInternalFindFunction* find_function) = 0;
-
- // Result of string search in the page.
- virtual void FindReply(content::WebContents* source,
- int request_id,
- int number_of_matches,
- const gfx::Rect& selection_rect,
- int active_match_ordinal,
- bool final_update) = 0;
-
// Returns the current zoom factor.
virtual double GetZoom() = 0;
@@ -75,9 +55,6 @@ class WebViewGuestDelegate {
// Called immediately after the guest WebContents has been destroyed.
virtual void OnGuestDestroyed() = 0;
- // Called to cancel all find sessions in progress.
- virtual void OnRenderProcessGone() = 0;
-
// Called when to set the zoom factor.
virtual void OnSetZoom(double zoom_factor) = 0;
@@ -88,16 +65,6 @@ class WebViewGuestDelegate {
virtual void OnShowContextMenu(
int request_id,
const MenuItemVector* items) = 0;
-
- // Conclude a find request to clear highlighting.
- virtual void StopFinding(content::StopFindAction) = 0;
-
- WebViewGuest* web_view_guest() const { return web_view_guest_; }
-
- private:
- WebViewGuest* const web_view_guest_;
-
- DISALLOW_COPY_AND_ASSIGN(WebViewGuestDelegate);
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698