Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2539)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 579563002: Find working in app_shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.h
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h
index 926a67b74f86f0fc068ba4bc3c481cfac4e94c8a..e7b3ad2b7f46a04247ab09cb2d339c72b1825f1c 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.h
+++ b/extensions/browser/guest_view/web_view/web_view_guest.h
@@ -13,6 +13,7 @@
#include "content/public/browser/notification_registrar.h"
#include "extensions/browser/guest_view/guest_view.h"
#include "extensions/browser/guest_view/web_view/javascript_dialog_helper.h"
+#include "extensions/browser/guest_view/web_view/web_view_find_helper.h"
#include "extensions/browser/guest_view/web_view/web_view_guest_delegate.h"
#include "extensions/browser/guest_view/web_view/web_view_permission_helper.h"
#include "extensions/browser/guest_view/web_view/web_view_permission_types.h"
@@ -162,10 +163,9 @@ class WebViewGuest : public GuestView<WebViewGuest>,
double GetZoom();
// Begin or continue a find request.
- void Find(
- const base::string16& search_text,
- const blink::WebFindOptions& options,
- WebViewInternalFindFunction* find_function);
+ void Find(const base::string16& search_text,
+ const blink::WebFindOptions& options,
+ scoped_refptr<WebViewInternalFindFunction> find_function);
// Conclude a find request to clear highlighting.
void StopFinding(content::StopFindAction);
@@ -312,6 +312,9 @@ class WebViewGuest : public GuestView<WebViewGuest>,
void SetUpAutoSize();
+ // Handles find requests and replies for the webview find API.
+ WebViewFindHelper find_helper_;
+
ObserverList<ScriptExecutionObserver> script_observers_;
scoped_ptr<ScriptExecutor> script_executor_;

Powered by Google App Engine
This is Rietveld 408576698