Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: extensions/browser/guest_view/web_view/web_view_find_helper.cc

Issue 579563002: Find working in app_shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase+cleanup Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_find_helper.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_find_helper.cc b/extensions/browser/guest_view/web_view/web_view_find_helper.cc
index 1da288fa271ab05dfff861a90f8e9cdc7e0f6f3f..9da8d1a322d3205d482398f410fa2ae8c247e66d 100644
--- a/extensions/browser/guest_view/web_view/web_view_find_helper.cc
+++ b/extensions/browser/guest_view/web_view/web_view_find_helper.cc
@@ -84,11 +84,10 @@ void WebViewFindHelper::EndFindSession(int session_request_id, bool canceled) {
find_info_map_.erase(session_request_id);
}
-void WebViewFindHelper::Find(
- content::WebContents* guest_web_contents,
- const base::string16& search_text,
- const blink::WebFindOptions& options,
- scoped_refptr<WebViewInternalFindFunction> find_function) {
+void WebViewFindHelper::Find(content::WebContents* guest_web_contents,
+ const base::string16& search_text,
+ const blink::WebFindOptions& options,
+ WebViewInternalFindFunction* find_function) {
Fady Samuel 2014/09/18 16:49:48 Why are you making this change?
// Need a new request_id for each new find request.
++current_find_request_id_;
@@ -241,7 +240,7 @@ WebViewFindHelper::FindInfo::FindInfo(
int request_id,
const base::string16& search_text,
const blink::WebFindOptions& options,
- scoped_refptr<WebViewInternalFindFunction> find_function)
+ WebViewInternalFindFunction* find_function)
: request_id_(request_id),
search_text_(search_text),
options_(options),

Powered by Google App Engine
This is Rietveld 408576698