Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 579543003: Revert of Set the javac target and source to 1.7 (Closed)

Created:
6 years, 3 months ago by aurimas (slooooooooow)
Modified:
6 years, 3 months ago
Reviewers:
cjhopman, Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, erikwright+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Set the javac target and source to 1.7 (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/545363002/) Reason for revert: Not all bots have Java 7 yet :( Original issue's description: > Set the javac target and source to 1.7 > > BUG=336589 > TBR=yfriedman@chromium.org > > Committed: https://crrev.com/165c0f17fe5760a3f346940d4fb2574d62cfe53b > Cr-Commit-Position: refs/heads/master@{#295162} TBR=cjhopman@chromium.org,yfriedman@chromium.org NOTREECHECKS=true NOTRY=true BUG=336589 Committed: https://crrev.com/094138696e943744d1489ebb98276b116eafed99 Cr-Commit-Position: refs/heads/master@{#295165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M base/android/java/src/org/chromium/base/CollectionUtil.java View 1 chunk +0 lines, -2 lines 0 comments Download
M build/android/gyp/javac.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aurimas (slooooooooow)
Created Revert of Set the javac target and source to 1.7
6 years, 3 months ago (2014-09-16 22:47:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579543003/1
6 years, 3 months ago (2014-09-16 22:48:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as d0d537826cdfbe3cf468467f5ece78b4a52979cc
6 years, 3 months ago (2014-09-16 22:49:40 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/094138696e943744d1489ebb98276b116eafed99 Cr-Commit-Position: refs/heads/master@{#295165}
6 years, 3 months ago (2014-09-16 22:50:32 UTC) #4
aurimas (slooooooooow)
6 years, 3 months ago (2014-09-25 01:23:55 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://chromiumcodereview.appspot.com/601983002/ by aurimas@chromium.org.

The reason for reverting is: All the bots have been switched to Java 7 according
to https://code.google.com/p/chromium/issues/detail?id=411503#c19.

Powered by Google App Engine
This is Rietveld 408576698