Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 579503003: Revert of mojo: Create a basic clipboard. (Closed)

Created:
6 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of mojo: Create a basic clipboard. (patchset #29 id:540001 of https://codereview.chromium.org/562483002/) Reason for revert: Breaking GN builders. http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&number=10604 http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/12120/steps/gn/logs/stdio Original issue's description: > mojo: Create a basic clipboard. > > This creates a basic clipboard interface and uses it from > html_viewer. This is a minimal implementation and does not actually > interact with the system clipboard. > > BUG=411039 > > Committed: https://crrev.com/757286d8a2c778fe4622890140c9b9d2afd21063 > Cr-Commit-Position: refs/heads/master@{#295143} TBR=dcheng@chromium.org,darin@chromium.org,sky@chromium.org,erg@chromium.org NOTREECHECKS=true NOTRY=true BUG=411039 Committed: https://crrev.com/ae48dc2800a7f37030952ddfee957513da558ab9 Cr-Commit-Position: refs/heads/master@{#295152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -922 lines) Patch
M mojo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/common/common_type_converters.h View 2 chunks +0 lines, -15 lines 0 comments Download
M mojo/common/common_type_converters.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M mojo/common/common_type_converters_unittest.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/mojo_services.gypi View 3 chunks +0 lines, -56 lines 0 comments Download
M mojo/public/cpp/bindings/array.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/services/clipboard/BUILD.gn View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/services/clipboard/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/services/clipboard/clipboard_standalone_impl.h View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/services/clipboard/clipboard_standalone_impl.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D mojo/services/clipboard/clipboard_standalone_unittest.cc View 1 chunk +0 lines, -185 lines 0 comments Download
D mojo/services/clipboard/main.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M mojo/services/html_viewer/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/services/html_viewer/blink_basic_type_converters.h View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/blink_basic_type_converters.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.cc View 3 chunks +0 lines, -9 lines 0 comments Download
D mojo/services/html_viewer/webclipboard_impl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D mojo/services/html_viewer/webclipboard_impl.cc View 1 chunk +0 lines, -222 lines 0 comments Download
D mojo/services/public/interfaces/clipboard/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/public/interfaces/clipboard/clipboard.mojom View 1 chunk +0 lines, -52 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 5 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Rockot(use gerrit already)
Created Revert of mojo: Create a basic clipboard.
6 years, 3 months ago (2014-09-16 21:53:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579503003/1
6 years, 3 months ago (2014-09-16 21:54:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as b62baa85919c04d226b697f53cfa03b75eed2750
6 years, 3 months ago (2014-09-16 21:55:27 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 21:55:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae48dc2800a7f37030952ddfee957513da558ab9
Cr-Commit-Position: refs/heads/master@{#295152}

Powered by Google App Engine
This is Rietveld 408576698