Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 579463002: Remove obsolete SPDY test exclusions. (Closed)

Created:
6 years, 3 months ago by Bence
Modified:
6 years, 3 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete SPDY test exclusions. SpdyNetworkTransactionSpdy*Test has been removed in https://crrev.com/16816010. SpdyHttpStreamSpdy*Test has been removed in https://crrev.com/17004007. These two exclusions are now obsolete. BUG=118883 NOTRY=true Committed: https://crrev.com/a337df3d8b29586e938948b0d53b2772baa0a4ad Cr-Commit-Position: refs/heads/master@{#295106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tools/valgrind/gtest_exclude/net_unittests.gtest.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
PTAL.
6 years, 3 months ago (2014-09-16 18:18:34 UTC) #2
Timur Iskhodzhanov
LGTM Please use NOTRY=true for Valgrind suppressions/exclusions to reduce load on trybots
6 years, 3 months ago (2014-09-16 18:24:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579463002/1
6 years, 3 months ago (2014-09-16 18:26:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as c7e36438b2b1ef2902e7515253fb26ee6798d7d8
6 years, 3 months ago (2014-09-16 18:29:33 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 18:32:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a337df3d8b29586e938948b0d53b2772baa0a4ad
Cr-Commit-Position: refs/heads/master@{#295106}

Powered by Google App Engine
This is Rietveld 408576698