Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 579443005: Add catch_exception_tool (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add catch_exception_tool. catch_exception_tool catches Mach exceptions. Currenlty, it simply prints a message with some information about each exception it handles. In the future, it will be tied to the minidump generator as well. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/f764db270fb24c3144e8e8811ea1a6621671a63f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -0 lines) Patch
A tools/catch_exception_tool.cc View 1 chunk +289 lines, -0 lines 1 comment Download
M tools/tools.gyp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
This depends on https://codereview.chromium.org/574753003/.
6 years, 3 months ago (2014-09-16 21:50:22 UTC) #2
Robert Sesek
https://codereview.chromium.org/579443005/diff/1/tools/catch_exception_tool.cc File tools/catch_exception_tool.cc (right): https://codereview.chromium.org/579443005/diff/1/tools/catch_exception_tool.cc#newcode125 tools/catch_exception_tool.cc:125: int sig = (code[0] >> 24) & 0xff; You've ...
6 years, 3 months ago (2014-09-17 16:28:04 UTC) #3
Mark Mentovai
Yes, this is the next thing I was going to send out. Do you want ...
6 years, 3 months ago (2014-09-17 16:31:22 UTC) #4
Robert Sesek
No, fine to refactor that separately. LGTM
6 years, 3 months ago (2014-09-17 16:32:04 UTC) #5
Mark Mentovai
6 years, 3 months ago (2014-09-17 19:40:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as f764db2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698