Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 57943005: app_list: Clear start page contents on NOTIFICATION_PROFILE_DESTROYED (Closed)

Created:
7 years, 1 month ago by xiyuan
Modified:
7 years, 1 month ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

app_list: Clear start page contents on NOTIFICATION_PROFILE_DESTROYED NOTIFICATION_APP_TERMINATING could happen before closing app list bubble on shutdown and breaks the assumption that start page contents should out-live app list. BUG=314567 R=mukai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M chrome/browser/ui/app_list/start_page_service.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
xiyuan
7 years, 1 month ago (2013-11-04 21:33:49 UTC) #1
Jun Mukai
lgtm
7 years, 1 month ago (2013-11-04 21:42:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/57943005/1
7 years, 1 month ago (2013-11-04 21:52:59 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219034
7 years, 1 month ago (2013-11-05 02:35:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/57943005/1
7 years, 1 month ago (2013-11-05 03:27:04 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184810
7 years, 1 month ago (2013-11-05 06:20:55 UTC) #6
xiyuan
7 years, 1 month ago (2013-11-05 17:18:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r233015 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698