Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 579383003: Uses the correct scale factor for fallback images on iOS. (Closed)

Created:
6 years, 3 months ago by rohitrao (ping after 24h)
Modified:
6 years, 3 months ago
Reviewers:
tony, lliabraa
CC:
chromium-reviews, lliabraa, stuartmorgan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Uses the correct scale factor for fallback images on iOS. Fallback images should always have a source scale factor of 1.0, even on 300P devices. BUG=413300, 415616 TEST=None Committed: https://crrev.com/fb35e64ae36246591dbda7a1f90772c2ffc03d8b Cr-Commit-Position: refs/heads/master@{#295703}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ui/base/resource/resource_bundle_ios.mm View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
lliabraa
lgtm
6 years, 3 months ago (2014-09-19 12:42:48 UTC) #2
rohitrao (ping after 24h)
+tony for OWNERS approval +lliabraa, stuartmorgan FYI One small fix, since I misunderstood how fallback ...
6 years, 3 months ago (2014-09-19 12:43:35 UTC) #4
tony
LGTM
6 years, 3 months ago (2014-09-19 13:31:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579383003/40001
6 years, 3 months ago (2014-09-19 13:34:07 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 3d9d6b1814865d64cea159a639e1e517f90f9260
6 years, 3 months ago (2014-09-19 14:34:15 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 14:34:49 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fb35e64ae36246591dbda7a1f90772c2ffc03d8b
Cr-Commit-Position: refs/heads/master@{#295703}

Powered by Google App Engine
This is Rietveld 408576698