Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 579383002: Revert of mojo: Add deserialization to python structs. (Closed)

Created:
6 years, 3 months ago by Elliot Glaysher
Modified:
6 years, 3 months ago
Reviewers:
Chris Masone, sdefresne, qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of mojo: Add deserialization to python structs. (patchset #3 id:40001 of https://codereview.chromium.org/578263003/) Reason for revert: New unit tests fail. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13695 Original issue's description: > mojo: Add deserialization to python structs. > > BUG=415491 > R=sdefresne@chromium.org,cmasone@chromium.org > > Committed: https://crrev.com/ea8a6ef576c314506c4b3ee25544f6bcaa895fe1 > Cr-Commit-Position: refs/heads/master@{#295478} TBR=cmasone@chromium.org,sdefresne@chromium.org,qsr@chromium.org NOTREECHECKS=true NOTRY=true BUG=415491 Committed: https://crrev.com/d4a62b87d28f0bda1c9453f02d9ea22fccaf700c Cr-Commit-Position: refs/heads/master@{#295522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -252 lines) Patch
M mojo/public/python/mojo/bindings/descriptor.py View 18 chunks +19 lines, -129 lines 0 comments Download
M mojo/public/python/mojo/bindings/reflection.py View 1 chunk +0 lines, -8 lines 0 comments Download
M mojo/public/python/mojo/bindings/serialization.py View 3 chunks +6 lines, -32 lines 0 comments Download
M mojo/python/tests/bindings_serialization_deserialization_unittest.py View 3 chunks +4 lines, -83 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
Created Revert of mojo: Add deserialization to python structs.
6 years, 3 months ago (2014-09-18 19:22:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579383002/1
6 years, 3 months ago (2014-09-18 19:23:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7ea0e7d34f90882997b62136034fe2e9f2d5b2a0
6 years, 3 months ago (2014-09-18 19:25:19 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d4a62b87d28f0bda1c9453f02d9ea22fccaf700c Cr-Commit-Position: refs/heads/master@{#295522}
6 years, 3 months ago (2014-09-18 19:26:16 UTC) #4
qsr
lgtm
6 years, 3 months ago (2014-09-19 09:00:33 UTC) #5
sdefresne
6 years, 3 months ago (2014-09-19 09:04:51 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698