Issue 57933002: Declarative API: Signal RulesRegister ready on correct thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 57933002: Declarative API: Signal RulesRegister ready on correct thread (Closed)

Created:
7 years, 1 month ago by Fady Samuel

Modified:
7 years, 1 month ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Declarative API: Signal RulesRegister ready on correct thread Currently the RulesRegistry may be marked as ready on a different thread than the owner thread which can be racy and fails an assert in debug builds. BUG=312461 TBR=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232905

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/extensions/api/declarative/rules_registry.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

vabr (Chromium)

LGTM, thanks for catching this! You will probably need an OWNERS approval, but I guess ...

7 years, 1 month ago (2013-11-04 15:42:20 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/57933002/1

7 years, 1 month ago (2013-11-04 15:55:45 UTC) #2

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 1 month ago (2013-11-04 16:18:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/57933002/1

7 years, 1 month ago (2013-11-04 17:50:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/57933002/1

7 years, 1 month ago (2013-11-05 03:26:36 UTC) #5

Message was sent while issue was closed.

Change committed as 232905