Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: Source/core/animation/css/CSSAnimations.cpp

Issue 579253002: Change StyleResolver::document() to be private (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/css/CSSAnimations.cpp
diff --git a/Source/core/animation/css/CSSAnimations.cpp b/Source/core/animation/css/CSSAnimations.cpp
index 7ef17650d7e287147efd9aa61ef85e1ff87f13c9..7dc1628605b7bff41b52f0ec20a663bacfa985dc 100644
--- a/Source/core/animation/css/CSSAnimations.cpp
+++ b/Source/core/animation/css/CSSAnimations.cpp
@@ -201,7 +201,7 @@ static void resolveKeyframes(StyleResolver* resolver, const Element* animatingEl
const StyleRuleKeyframes* CSSAnimations::matchScopedKeyframesRule(StyleResolver* resolver, const Element* element, const StringImpl* animationName)
{
// FIXME: This is all implementation detail of style resolver, CSSAnimations shouldn't be reaching into any of it.
rune 2014/09/24 08:16:20 Fixing this FIXME would make more sense.
Timothy Loh 2014/09/24 08:20:10 I think esprehn has a patch up for this somewhere.
esprehn 2014/09/24 08:39:33 Yeah we can do that in a separate patch.
- if (resolver->document().styleEngine()->hasOnlyScopedResolverForDocument())
+ if (element->document().styleEngine()->hasOnlyScopedResolverForDocument())
return element->document().scopedStyleResolver()->keyframeStylesForAnimation(animationName);
WillBeHeapVector<RawPtrWillBeMember<ScopedStyleResolver>, 8> stack;
« no previous file with comments | « no previous file | Source/core/css/resolver/ScopedStyleResolver.cpp » ('j') | Source/core/css/resolver/ScopedStyleResolver.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698