Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: Source/core/css/resolver/StyleResolver.h

Issue 579253002: Change StyleResolver::document() to be private (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1
1 /* 2 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * 5 *
5 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
9 * 10 *
10 * This library is distributed in the hope that it will be useful, 11 * This library is distributed in the hope that it will be useful,
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 static PassRefPtrWillBeRawPtr<AnimatableValue> createAnimatableValueSnapshot (StyleResolverState&, CSSPropertyID, CSSValue&); 112 static PassRefPtrWillBeRawPtr<AnimatableValue> createAnimatableValueSnapshot (StyleResolverState&, CSSPropertyID, CSSValue&);
112 113
113 PassRefPtr<RenderStyle> pseudoStyleForElement(Element*, const PseudoStyleReq uest&, RenderStyle* parentStyle); 114 PassRefPtr<RenderStyle> pseudoStyleForElement(Element*, const PseudoStyleReq uest&, RenderStyle* parentStyle);
114 115
115 PassRefPtr<RenderStyle> styleForPage(int pageIndex); 116 PassRefPtr<RenderStyle> styleForPage(int pageIndex);
116 PassRefPtr<RenderStyle> defaultStyleForElement(); 117 PassRefPtr<RenderStyle> defaultStyleForElement();
117 PassRefPtr<RenderStyle> styleForText(Text*); 118 PassRefPtr<RenderStyle> styleForText(Text*);
118 119
119 static PassRefPtr<RenderStyle> styleForDocument(Document&); 120 static PassRefPtr<RenderStyle> styleForDocument(Document&);
120 121
121 // FIXME: This only has 5 callers and should be removed. Callers should be e xplicit about
122 // their dependency on Document* instead of grabbing one through StyleResolv er.
123 Document& document() { return *m_document; }
124
125 // FIXME: It could be better to call appendAuthorStyleSheets() directly afte r we factor StyleResolver further. 122 // FIXME: It could be better to call appendAuthorStyleSheets() directly afte r we factor StyleResolver further.
126 // https://bugs.webkit.org/show_bug.cgi?id=108890 123 // https://bugs.webkit.org/show_bug.cgi?id=108890
127 void appendAuthorStyleSheets(const WillBeHeapVector<RefPtrWillBeMember<CSSSt yleSheet> >&); 124 void appendAuthorStyleSheets(const WillBeHeapVector<RefPtrWillBeMember<CSSSt yleSheet> >&);
128 void resetAuthorStyle(TreeScope&); 125 void resetAuthorStyle(TreeScope&);
129 void finishAppendAuthorStyleSheets(); 126 void finishAppendAuthorStyleSheets();
130 127
131 void processScopedRules(const RuleSet& authorRules, CSSStyleSheet*, unsigned sheetIndex, ContainerNode& scope); 128 void processScopedRules(const RuleSet& authorRules, CSSStyleSheet*, unsigned sheetIndex, ContainerNode& scope);
132 129
133 void lazyAppendAuthorStyleSheets(unsigned firstNew, const WillBeHeapVector<R efPtrWillBeMember<CSSStyleSheet> >&); 130 void lazyAppendAuthorStyleSheets(unsigned firstNew, const WillBeHeapVector<R efPtrWillBeMember<CSSStyleSheet> >&);
134 void removePendingAuthorStyleSheets(const WillBeHeapVector<RefPtrWillBeMembe r<CSSStyleSheet> >&); 131 void removePendingAuthorStyleSheets(const WillBeHeapVector<RefPtrWillBeMembe r<CSSStyleSheet> >&);
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 OwnPtr<StyleResolverStats> m_styleResolverStatsTotals; 302 OwnPtr<StyleResolverStats> m_styleResolverStatsTotals;
306 unsigned m_styleResolverStatsSequence; 303 unsigned m_styleResolverStatsSequence;
307 304
308 // Use only for Internals::updateStyleAndReturnAffectedElementCount. 305 // Use only for Internals::updateStyleAndReturnAffectedElementCount.
309 unsigned m_accessCount; 306 unsigned m_accessCount;
310 }; 307 };
311 308
312 } // namespace blink 309 } // namespace blink
313 310
314 #endif // StyleResolver_h 311 #endif // StyleResolver_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698