chrome/browser/ui/views/extensions/extension_popup.cc - Issue 57923009: Move ExtensionProcessManager to src/extensions, part 3 - remove Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 57923009: Move ExtensionProcessManager to src/extensions, part 3 - remove Browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add test Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_host_factory.cc ('K') | « chrome/browser/ui/views/extensions/extension_dialog.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_popup.cc

diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc

index 7b8d4efd380f56d0abd0a838deeed8aa4ddca3e0..9adb006904ec095a27300dc99b8b15c9aa9c13dd 100644

--- a/chrome/browser/ui/views/extensions/extension_popup.cc

+++ b/chrome/browser/ui/views/extensions/extension_popup.cc

@@ -8,8 +8,8 @@

#include "base/message_loop/message_loop.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/devtools/devtools_window.h"

-#include "chrome/browser/extensions/extension_process_manager.h"

-#include "chrome/browser/extensions/extension_system.h"

+#include "chrome/browser/extensions/extension_host.h"

+#include "chrome/browser/extensions/extension_host_factory.h"

#include "chrome/browser/platform_util.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

@@ -167,9 +167,8 @@ ExtensionPopup* ExtensionPopup::ShowPopup(const GURL& url,

views::View* anchor_view,

views::BubbleBorder::Arrow arrow,

ShowAction show_action) {

- ExtensionProcessManager* manager =

- extensions::ExtensionSystem::Get(browser->profile())->process_manager();

- extensions::ExtensionHost* host = manager->CreatePopupHost(url, browser);

+ extensions::ExtensionHost* host =

+ extensions::ExtensionHostFactory::CreatePopupHost(url, browser);

ExtensionPopup* popup = new ExtensionPopup(host, anchor_view, arrow,

show_action);

views::BubbleDelegateView::CreateBubble(popup);