Move ExtensionProcessManager to src/extensions, part 3 - remove Browser

chrome/browser/extensions/extension_host_factory.cc

Index: chrome/browser/extensions/extension_host_factory.cc
diff --git a/chrome/browser/extensions/extension_host_factory.cc b/chrome/browser/extensions/extension_host_factory.cc
new file mode 100644
index 0000000000000000000000000000000000000000..38fb3c09337a63e1899920da26313b371e9fedc7
--- /dev/null
+++ b/chrome/browser/extensions/extension_host_factory.cc
@@ -0,0 +1,145 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_host_factory.h"
+
+#include "chrome/browser/extensions/extension_host.h"
+#include "chrome/browser/extensions/extension_process_manager.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/extensions/extension_util.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/common/extensions/incognito_handler.h"
+#include "chrome/common/url_constants.h"
+#include "extensions/common/view_type.h"
+
+#if defined(OS_MACOSX)
+#include "chrome/browser/extensions/extension_host_mac.h"
+#endif
+
+namespace extensions {
+
+namespace {
+
+// Creates a new ExtensionHost with its associated view, grouping it in the
+// appropriate SiteInstance (and therefore process) based on the URL and
+// profile.
+ExtensionHost* CreateViewHostForExtension(const Extension* extension,
+                                          const GURL& url,
+                                          Profile* profile,
+                                          Browser* browser,
+                                          ViewType view_type) {
+  DCHECK(profile);
+  // A NULL browser may only be given for dialogs.
+  DCHECK(browser || view_type == VIEW_TYPE_EXTENSION_DIALOG);
+  ExtensionProcessManager* pm =
+      ExtensionSystem::Get(profile)->process_manager();
+  content::SiteInstance* site_instance = pm->GetSiteInstanceForURL(url);
+  ExtensionHost* host =
+#if defined(OS_MACOSX)
+      new ExtensionHostMac(extension, site_instance, url, view_type);
+#else
+      new ExtensionHost(extension, site_instance, url, view_type);
+#endif
+  host->CreateView(browser);
+  pm->OnExtensionHostCreated(host, false);

[Yoyo Zhou, 2013/11/06 03:24:47]

I'm not sure we need this. It's pretty much a no-op and we could copy the DCHECK
to here if necessary.

[James Cook, 2013/11/06 16:50:34]

Good catch. I just removed the call. Looking at ExtensionHost I think the DCHECK
isn't necessary -- both ExtensionProcessManager and ExtensionHost pull the same
Profile/BrowserContext from the SiteInstance, so they should always match.

+  return host;
+}
+
+// Return true if this extension can run in an incognito window.
+bool IsIncognitoEnabled(Profile* profile, const Extension* extension) {
+  ExtensionService* service =
+      ExtensionSystem::Get(profile)->extension_service();
+  return extension_util::IsIncognitoEnabled(extension->id(), service);
+}
+
+// Creates a view host for an extension in an incognito window. Returns NULL
+// if the extension is not allowed to run in incognito.
+ExtensionHost* CreateViewHostForIncognito(const Extension* extension,
+                                          const GURL& url,
+                                          Profile* profile,
+                                          Browser* browser,
+                                          ViewType view_type) {
+  DCHECK(extension);
+  DCHECK(profile->IsOffTheRecord());
+
+  if (!IncognitoInfo::IsSplitMode(extension)) {
+    // If it's not split-mode the host is associated with the original profile.
+    Profile* original_profile = profile->GetOriginalProfile();
+    return CreateViewHostForExtension(

[James Cook, 2013/11/06 00:16:40]

This is the behavior of the original code, but I'm a little puzzled that we
don't check IsIncognitoEnabled() for non-split-mode extensions.  See the
original code in extension_process_manager.cc.

[Yoyo Zhou, 2013/11/06 03:24:47]

I'm puzzled by this too, but it appears to have been this way since the
beginning. I think it's okay to leave it as is.

+        extension, url, original_profile, browser, view_type);
+  }
+
+  // Create the host if the extension can run in incognito.
+  if (IsIncognitoEnabled(profile, extension)) {
+    return CreateViewHostForExtension(
+        extension, url, profile, browser, view_type);
+  }
+  NOTREACHED() <<
+      "We shouldn't be trying to create an incognito extension view unless "
+      "it has been enabled for incognito.";
+  return NULL;
+}
+
+// Returns the extension associated with |url| in |profile|. Returns NULL if
+// the extension does not exist.
+const Extension* GetExtensionForUrl(Profile* profile, const GURL& url) {
+  ExtensionService* service =
+      ExtensionSystem::Get(profile)->extension_service();
+  if (!service)
+    return NULL;
+  std::string extension_id = url.host();
+  if (url.SchemeIs(chrome::kChromeUIScheme) &&
+      url.host() == chrome::kChromeUIExtensionInfoHost)
+    extension_id = url.path().substr(1);
+  return service->extensions()->GetByID(extension_id);
+}
+
+// Creates and initializes an ExtensionHost for the extension with |url|.
+ExtensionHost* CreateViewHost(const GURL& url,
+                              Profile* profile,
+                              Browser* browser,
+                              extensions::ViewType view_type) {
+  DCHECK(profile);
+  // A NULL browser may only be given for dialogs.
+  DCHECK(browser || view_type == VIEW_TYPE_EXTENSION_DIALOG);
+
+  const Extension* extension = GetExtensionForUrl(profile, url);
+  if (!extension)
+    return NULL;
+  if (profile->IsOffTheRecord()) {
+    return CreateViewHostForIncognito(
+        extension, url, profile, browser, view_type);
+  }
+  return CreateViewHostForExtension(
+      extension, url, profile, browser, view_type);
+}
+
+}  // namespace
+
+// static
+ExtensionHost* ExtensionHostFactory::CreatePopupHost(const GURL& url,
+                                                     Browser* browser) {
+  DCHECK(browser);
+  return CreateViewHost(
+      url, browser->profile(), browser, VIEW_TYPE_EXTENSION_POPUP);
+}
+
+// static
+ExtensionHost* ExtensionHostFactory::CreateInfobarHost(const GURL& url,
+                                                       Browser* browser) {
+  DCHECK(browser);
+  return CreateViewHost(
+      url, browser->profile(), browser, VIEW_TYPE_EXTENSION_INFOBAR);
+}
+
+// static
+ExtensionHost* ExtensionHostFactory::CreateDialogHost(const GURL& url,
+                                                      Profile* profile) {
+  DCHECK(profile);
+  return CreateViewHost(url, profile, NULL, VIEW_TYPE_EXTENSION_DIALOG);
+}
+
+}  // namespace extensions