Move ExtensionProcessManager to src/extensions, part 3 - remove Browser

Move ExtensionProcessManager to src/extensions, part 3 - remove Browser

Introduce ExtensionHostFactory to hold Browser-specific ExtensionHost
creation.

BUG=313481
TEST=browser_tests, unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233504

[James Cook, 2013-11-05 22:52:27]

yoz, PTAL

https://codereview.chromium.org/57923009/diff/40001/chrome/browser/extensions...
File chrome/browser/extensions/extension_host_factory.cc (right):

https://codereview.chromium.org/57923009/diff/40001/chrome/browser/extensions...
chrome/browser/extensions/extension_host_factory.cc:71: return
CreateViewHostForExtension(
This is the behavior of the original code, but I'm a little puzzled that we
don't check IsIncognitoEnabled() for non-split-mode extensions.  See the
original code in extension_process_manager.cc.

[James Cook, 2013-11-06 00:16:40]

https://codereview.chromium.org/57923009/diff/140001/chrome/browser/extension...
File chrome/browser/extensions/extension_host_factory.cc (right):

https://codereview.chromium.org/57923009/diff/140001/chrome/browser/extension...
chrome/browser/extensions/extension_host_factory.cc:71: return
CreateViewHostForExtension(
This is the behavior of the original code, but I'm a little puzzled that we
don't check IsIncognitoEnabled() for non-split-mode extensions.  See the
original code in extension_process_manager.cc.

[Yoyo Zhou, 2013-11-06 03:24:47]

https://chromiumcodereview.appspot.com/57923009/diff/140001/chrome/browser/ex...
File chrome/browser/extensions/extension_host_factory.cc (right):

https://chromiumcodereview.appspot.com/57923009/diff/140001/chrome/browser/ex...
chrome/browser/extensions/extension_host_factory.cc:47:
pm->OnExtensionHostCreated(host, false);
I'm not sure we need this. It's pretty much a no-op and we could copy the DCHECK
to here if necessary.

https://chromiumcodereview.appspot.com/57923009/diff/140001/chrome/browser/ex...
chrome/browser/extensions/extension_host_factory.cc:71: return
CreateViewHostForExtension(
On 2013/11/06 00:16:40, James Cook wrote:
> This is the behavior of the original code, but I'm a little puzzled that we
> don't check IsIncognitoEnabled() for non-split-mode extensions.  See the
> original code in extension_process_manager.cc.

I'm puzzled by this too, but it appears to have been this way since the
beginning. I think it's okay to leave it as is.

[James Cook, 2013-11-06 16:50:33]

yoz, please take another look

sky, can I get OWNERS approval for chrome/browser/ui/ ?  This moves some
extension host creation code to a factory class.

https://codereview.chromium.org/57923009/diff/140001/chrome/browser/extension...
File chrome/browser/extensions/extension_host_factory.cc (right):

https://codereview.chromium.org/57923009/diff/140001/chrome/browser/extension...
chrome/browser/extensions/extension_host_factory.cc:47:
pm->OnExtensionHostCreated(host, false);
On 2013/11/06 03:24:47, Yoyo Zhou wrote:
> I'm not sure we need this. It's pretty much a no-op and we could copy the
DCHECK
> to here if necessary.

Good catch. I just removed the call. Looking at ExtensionHost I think the DCHECK
isn't necessary -- both ExtensionProcessManager and ExtensionHost pull the same
Profile/BrowserContext from the SiteInstance, so they should always match.

[Yoyo Zhou, 2013-11-06 19:08:07]

LGTM

https://chromiumcodereview.appspot.com/57923009/diff/340001/chrome/browser/ex...
File chrome/browser/extensions/extension_process_manager.h (right):

https://chromiumcodereview.appspot.com/57923009/diff/340001/chrome/browser/ex...
chrome/browser/extensions/extension_process_manager.h:122: void
OnExtensionHostCreated(extensions::ExtensionHost* host);
Can you rename this to OnBackgroundHostCreated and move it back to protected?

[sky, 2013-11-06 21:17:25]

LGTM

[commit-bot: I haz the power, 2013-11-06 22:47:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/57923009/520001

[commit-bot: I haz the power, 2013-11-07 06:29:25]

Change committed as 233504