Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 579183003: [New Tab Page] Update Fakebox input type to url. (Closed)

Created:
6 years, 3 months ago by rsadam
Modified:
6 years, 3 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update Fakebox input type to url. This should fix an issue with input events. BUG=414841 Committed: https://crrev.com/9683216a28b76556b2369336e9d77a38c7907edc Cr-Commit-Position: refs/heads/master@{#295508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/local_ntp/local_ntp.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
rsadam
Hi mathp, PTAL!
6 years, 3 months ago (2014-09-18 17:00:11 UTC) #2
Mathieu
As mentioned, please test all interactions carefully (copy, then paste using right click on fakebox). ...
6 years, 3 months ago (2014-09-18 17:24:13 UTC) #3
rsadam
Passed my manual tests, and beaudoin@ did some more as an extra sanity step - ...
6 years, 3 months ago (2014-09-18 18:17:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579183003/1
6 years, 3 months ago (2014-09-18 18:19:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as aadd61db7617b637aa6358c01f78702d7e84c6e4
6 years, 3 months ago (2014-09-18 18:47:56 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:49:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9683216a28b76556b2369336e9d77a38c7907edc
Cr-Commit-Position: refs/heads/master@{#295508}

Powered by Google App Engine
This is Rietveld 408576698