Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 579183002: Migrate browsertest to use ServiceWorkerRegistration.unregister() (Closed)

Created:
6 years, 3 months ago by Kunihiko Sakamoto
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, tfarina, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Migrate browsertest to use ServiceWorkerRegistration.unregister() ServiceWorkerContainer.unregister() is going away. This patch updates ServiceWorkerBrowserTest.ImportsBustMemcache to use ServiceWorkerRegistration.unregister() function. BUG=404064 Committed: https://crrev.com/4860e1362eb5541c160ef85ad1c75ce338752f6f Cr-Commit-Position: refs/heads/master@{#295664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/test/data/service_worker/imports_bust_memcache.html View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Kunihiko Sakamoto
6 years, 3 months ago (2014-09-18 11:03:02 UTC) #2
Kunihiko Sakamoto
adding a reviewer in JST
6 years, 3 months ago (2014-09-19 05:00:10 UTC) #4
dominicc (has gone to gerrit)
lgtm
6 years, 3 months ago (2014-09-19 05:03:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579183002/1
6 years, 3 months ago (2014-09-19 05:04:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6f506d6cb943cb2b67455eb2e8a31ec510ad065e
6 years, 3 months ago (2014-09-19 05:29:50 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 05:30:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4860e1362eb5541c160ef85ad1c75ce338752f6f
Cr-Commit-Position: refs/heads/master@{#295664}

Powered by Google App Engine
This is Rietveld 408576698