Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: src/ic/ic.cc

Issue 579153003: Move state sentinels into TypeFeedbackVector. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: ports. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ic.h ('k') | src/ic/ic-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic.cc
diff --git a/src/ic/ic.cc b/src/ic/ic.cc
index 17b7dcaf5a6e4da4277e44b83d892e9b8f799b99..70afa942898a59bb8f4761887d3a315b5de1a6f6 100644
--- a/src/ic/ic.cc
+++ b/src/ic/ic.cc
@@ -1826,8 +1826,8 @@ MaybeHandle<Object> KeyedStoreIC::Store(Handle<Object> object,
bool CallIC::DoCustomHandler(Handle<Object> receiver, Handle<Object> function,
- Handle<FixedArray> vector, Handle<Smi> slot,
- const CallICState& state) {
+ Handle<TypeFeedbackVector> vector,
+ Handle<Smi> slot, const CallICState& state) {
DCHECK(FLAG_use_ic && function->IsJSFunction());
// Are we the array function?
@@ -1861,12 +1861,14 @@ bool CallIC::DoCustomHandler(Handle<Object> receiver, Handle<Object> function,
void CallIC::PatchMegamorphic(Handle<Object> function,
- Handle<FixedArray> vector, Handle<Smi> slot) {
+ Handle<TypeFeedbackVector> vector,
+ Handle<Smi> slot) {
CallICState state(target()->extra_ic_state());
IC::State old_state = FeedbackToState(vector, slot);
// We are going generic.
- vector->set(slot->value(), *TypeFeedbackInfo::MegamorphicSentinel(isolate()),
+ vector->set(slot->value(),
+ *TypeFeedbackVector::MegamorphicSentinel(isolate()),
SKIP_WRITE_BARRIER);
CallICStub stub(isolate(), state);
@@ -1886,7 +1888,7 @@ void CallIC::PatchMegamorphic(Handle<Object> function,
void CallIC::HandleMiss(Handle<Object> receiver, Handle<Object> function,
- Handle<FixedArray> vector, Handle<Smi> slot) {
+ Handle<TypeFeedbackVector> vector, Handle<Smi> slot) {
CallICState state(target()->extra_ic_state());
IC::State old_state = FeedbackToState(vector, slot);
Handle<Object> name = isolate()->factory()->empty_string();
@@ -1898,7 +1900,7 @@ void CallIC::HandleMiss(Handle<Object> receiver, Handle<Object> function,
if (feedback->IsJSFunction() || !function->IsJSFunction()) {
// We are going generic.
vector->set(slot->value(),
- *TypeFeedbackInfo::MegamorphicSentinel(isolate()),
+ *TypeFeedbackVector::MegamorphicSentinel(isolate()),
SKIP_WRITE_BARRIER);
} else {
// The feedback is either uninitialized or an allocation site.
@@ -1907,7 +1909,7 @@ void CallIC::HandleMiss(Handle<Object> receiver, Handle<Object> function,
// merely need to patch the target to match the feedback.
// TODO(mvstanton): the better approach is to dispense with patching
// altogether, which is in progress.
- DCHECK(feedback == *TypeFeedbackInfo::UninitializedSentinel(isolate()) ||
+ DCHECK(feedback == *TypeFeedbackVector::UninitializedSentinel(isolate()) ||
feedback->IsAllocationSite());
// Do we want to install a custom handler?
@@ -1945,7 +1947,7 @@ RUNTIME_FUNCTION(CallIC_Miss) {
CallIC ic(isolate);
Handle<Object> receiver = args.at<Object>(0);
Handle<Object> function = args.at<Object>(1);
- Handle<FixedArray> vector = args.at<FixedArray>(2);
+ Handle<TypeFeedbackVector> vector = args.at<TypeFeedbackVector>(2);
Handle<Smi> slot = args.at<Smi>(3);
ic.HandleMiss(receiver, function, vector, slot);
return *function;
@@ -1959,7 +1961,7 @@ RUNTIME_FUNCTION(CallIC_Customization_Miss) {
// A miss on a custom call ic always results in going megamorphic.
CallIC ic(isolate);
Handle<Object> function = args.at<Object>(1);
- Handle<FixedArray> vector = args.at<FixedArray>(2);
+ Handle<TypeFeedbackVector> vector = args.at<TypeFeedbackVector>(2);
Handle<Smi> slot = args.at<Smi>(3);
ic.PatchMegamorphic(function, vector, slot);
return *function;
« no previous file with comments | « src/ic/ic.h ('k') | src/ic/ic-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698