Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 579153003: Move state sentinels into TypeFeedbackVector. (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move state sentinels into TypeFeedbackVector. These sentinels were in the wrong place, living in only tangentially related class TypeFeedbackInfo, but they codify state in the TypeFeedbackVector. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24037

Patch Set 1 : Rebase. #

Patch Set 2 : ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -107 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/ic/ic.cc View 7 chunks +11 lines, -9 lines 0 comments Download
M src/ic/ic-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +0 lines, -22 lines 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +1 line, -32 lines 0 comments Download
M src/type-feedback-vector.h View 1 1 chunk +21 lines, -0 lines 0 comments Download
M src/type-feedback-vector.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A src/type-feedback-vector-inl.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
M src/type-info.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 4 chunks +7 lines, -8 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mvstanton
Hi Igor, Here is that follow up, it does: a) moves sentinels into TypeFeedbackVector where ...
6 years, 3 months ago (2014-09-18 11:43:30 UTC) #5
Igor Sheludko
lgtm
6 years, 3 months ago (2014-09-18 12:26:18 UTC) #6
mvstanton
6 years, 3 months ago (2014-09-18 12:31:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:80001) manually as 24037 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698