Add update observer to file_system_operation_impl_unittest for

Add update observer to file_system_operation_impl_unittest for
the notification order test.

* Before this patch, file_system_operation_impl_unittest can not test
  the notification order because it doesn't have the update observer.

BUG=410198
TEST=content_unittests

Committed: https://crrev.com/44f31e7db9855cc8acf4648519af2dac9cb5cf45
Cr-Commit-Position: refs/heads/master@{#295914}

[iseki, 2014-09-18 09:35:11]

iseki@chromium.org changed reviewers:
+ tzik@chromium.org

[iseki, 2014-09-18 09:35:11]

Please take a look:)

[tzik, 2014-09-19 03:44:00]

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/file...
File content/browser/fileapi/file_system_operation_impl_unittest.cc (right):

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/file...
content/browser/fileapi/file_system_operation_impl_unittest.cc:70:
update_observer_.EndCount();
EndCount() looks a bit weird.
How about renaming it with {Enable,Disable}Verification()?

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/mock...
File content/browser/fileapi/mock_file_update_observer.cc (right):

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/mock...
content/browser/fileapi/mock_file_update_observer.cc:10:
MockFileUpdateObserver::MockFileUpdateObserver() {}
|is_ready_| needs to be initialized here.

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/mock...
content/browser/fileapi/mock_file_update_observer.cc:18: return
list.AddObserver(observer, base::MessageLoopProxy::current().get());
Since MessageLoopProxy is moderately deprecated, can we replace it with
ThreadTaskRunnerHandle::Get()?

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/mock...
File content/browser/fileapi/mock_file_update_observer.h (right):

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/mock...
content/browser/fileapi/mock_file_update_observer.h:43:
std::map<base::FilePath::StringType, int> start_update_count_;
Can we just use FileSystemURL instead of FilePath? The path part can conflict to
other file.
FileSystemURL::Comparator will be needed for the third template parameter.

[iseki, 2014-09-19 04:55:29]

Thank you for your review.

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/file...
File content/browser/fileapi/file_system_operation_impl_unittest.cc (right):

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/file...
content/browser/fileapi/file_system_operation_impl_unittest.cc:70:
update_observer_.EndCount();
On 2014/09/19 03:43:59, tzik wrote:
> EndCount() looks a bit weird.
> How about renaming it with {Enable,Disable}Verification()?

Done.

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/mock...
File content/browser/fileapi/mock_file_update_observer.cc (right):

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/mock...
content/browser/fileapi/mock_file_update_observer.cc:10:
MockFileUpdateObserver::MockFileUpdateObserver() {}
On 2014/09/19 03:44:00, tzik wrote:
> |is_ready_| needs to be initialized here.

Done.

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/mock...
content/browser/fileapi/mock_file_update_observer.cc:18: return
list.AddObserver(observer, base::MessageLoopProxy::current().get());
On 2014/09/19 03:44:00, tzik wrote:
> Since MessageLoopProxy is moderately deprecated, can we replace it with
> ThreadTaskRunnerHandle::Get()?

Done.

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/mock...
File content/browser/fileapi/mock_file_update_observer.h (right):

https://codereview.chromium.org/579153002/diff/1/content/browser/fileapi/mock...
content/browser/fileapi/mock_file_update_observer.h:43:
std::map<base::FilePath::StringType, int> start_update_count_;
On 2014/09/19 03:44:00, tzik wrote:
> Can we just use FileSystemURL instead of FilePath? The path part can conflict
to
> other file.
> FileSystemURL::Comparator will be needed for the third template parameter.

Done.

[tzik, 2014-09-19 06:18:06]

lgtm

[iseki, 2014-09-19 06:22:36]

Thanks:)

[iseki, 2014-09-19 06:28:42]

iseki@chromium.org changed reviewers:
+ sky@chromium.org

[iseki, 2014-09-19 06:28:42]

Please take a look.
@sky
content/public/test/sandbox_file_system_test_helper.h
content/public/test/sandbox_file_system_test_helper.cc

[sky, 2014-09-19 15:26:39]

LGTM

[iseki, 2014-09-20 00:24:47]

Thanks:)

[iseki, 2014-09-20 00:24:55]

The CQ bit was checked by iseki@chromium.org

[commit-bot: I haz the power, 2014-09-20 00:25:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/579153002/20001

[commit-bot: I haz the power, 2014-09-20 02:27:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-20 02:27:36]

Exceeded time limit waiting for builds to trigger.

[iseki, 2014-09-21 23:48:24]

The CQ bit was checked by iseki@chromium.org

[commit-bot: I haz the power, 2014-09-21 23:49:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/579153002/20001

[commit-bot: I haz the power, 2014-09-22 03:47:17]

Committed patchset #2 (id:20001) as f2f297890464749f6b1fd25eecd620206d5c8a88

[commit-bot: I haz the power, 2014-09-22 03:47:55]

Patchset 2 (id:??) landed as
https://crrev.com/44f31e7db9855cc8acf4648519af2dac9cb5cf45
Cr-Commit-Position: refs/heads/master@{#295914}