Issue 579133002: Default value of |size| IDL attribute of HTMLSelectElement should be 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 579133002: Default value of |size| IDL attribute of HTMLSelectElement should be 0. (Closed)

Created:
6 years, 3 months ago by tkent

Modified:
6 years, 3 months ago

Reviewers:
keishi

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Default value of |size| IDL attribute of HTMLSelectElement should be 0. https://html.spec.whatwg.org/multipage/forms.html#dom-select-size > The size IDL attribute has a default value of zero. The new behavior is compatible with IE and Firefox. BUG=415456 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182223

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -1 line)			Patch
A	LayoutTests/fast/forms/select/select-size.html	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/forms/select/select-size-expected.txt	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLSelectElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

tkent

Please review this. This CL is a preparation to fix crbug.com/4579. Without this change, we ...

6 years, 3 months ago (2014-09-18 07:07:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/579133002/1

6 years, 3 months ago (2014-09-18 07:39:52 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-18 08:11:00 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 182223