Issue 57913002: Refactor how the DeviceMonitor is started.

Issue 57913002: Refactor how the DeviceMonitor is started. (Closed)

Created:
7 years, 1 month ago by perkj_chrome

Modified:
7 years ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews, fischman+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor how the MediaStreamManager::DeviceMonitor is started. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238409

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -13 lines)			Patch
M	content/browser/media/media_devices_monitor.cc	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	content/browser/renderer_host/media/media_stream_manager.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/media/media_stream_manager.cc	View	1	2 chunks	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

no longer working on chromium

https://codereview.chromium.org/57913002/diff/1/content/browser/media/media_devices_monitor.cc File content/browser/media/media_devices_monitor.cc (right): https://codereview.chromium.org/57913002/diff/1/content/browser/media/media_devices_monitor.cc#newcode15 content/browser/media/media_devices_monitor.cc:15: media_stream_manager->StartMonitoring(); This EnsureMonitorCaptureDevicesInternal is triggered event time there is ...

7 years, 1 month ago (2013-11-04 15:51:21 UTC) #2

no longer working on chromium

On 2013/12/02 19:59:33, perkj wrote: > PTAL lgtm

7 years ago (2013-12-03 14:20:43 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/57913002/80001

7 years ago (2013-12-03 14:36:36 UTC) #5

Message was sent while issue was closed.

Change committed as 238409

Expand Messages | Collapse Messages