Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 579093002: App list: Crop all switcher button icons to 24x24. (Closed)

Created:
6 years, 3 months ago by Matt Giuca
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, oshima+watch_chromium.org, calamity
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

App list: Crop all switcher button icons to 24x24. Previously, the images had padding to make them 32x32 (the size of the button). Now the button size is set programmatically, so the images can be as small as the actual graphic within. BUG=411775 Committed: https://crrev.com/6daafb7557f85912ab359dce9b53c622980f16df Cr-Commit-Position: refs/heads/master@{#295942}

Patch Set 1 #

Patch Set 2 : Get image size before losing ownership of the image. #

Patch Set 3 : Re-crop icons to a standard 24x24 instead of minimal cropping. #

Patch Set 4 : png crushing #

Patch Set 5 : Move code changes to precursor CLs (and rewrite). #

Messages

Total messages: 10 (3 generated)
Matt Giuca
calamity: code oshima: images
6 years, 3 months ago (2014-09-18 05:20:39 UTC) #2
oshima
ui/resources lgtm
6 years, 3 months ago (2014-09-18 07:57:25 UTC) #3
Matt Giuca
Oops, pngs have now been crushed.
6 years, 3 months ago (2014-09-18 08:25:27 UTC) #4
Matt Giuca
The code has been moved out to a separate precursor CL. Calamity removed as reviewer.
6 years, 3 months ago (2014-09-19 09:23:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/579093002/70001
6 years, 3 months ago (2014-09-22 07:42:48 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:70001) as e987f3c68f70884e1d7fd2e12e89d6b9cf14bbf7
6 years, 3 months ago (2014-09-22 08:59:35 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 09:00:18 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6daafb7557f85912ab359dce9b53c622980f16df
Cr-Commit-Position: refs/heads/master@{#295942}

Powered by Google App Engine
This is Rietveld 408576698