FileSystem: Modify ObfucatedFileUtil to delete contents of the plugin private filesystem

storage/browser/fileapi/obfuscated_file_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "storage/browser/fileapi/obfuscated_file_util.h"
 
 #include <queue>
 #include <string>
 #include <vector>
 
 #include "base/files/file_util.h"
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
+#include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "storage/browser/fileapi/file_observers.h"
 #include "storage/browser/fileapi/file_system_context.h"
 #include "storage/browser/fileapi/file_system_operation_context.h"
 #include "storage/browser/fileapi/file_system_url.h"
 #include "storage/browser/fileapi/native_file_util.h"
 #include "storage/browser/fileapi/sandbox_file_system_backend.h"
@@ skipping 871 matching lines @@
   if (origin_database_) {
     origin_database_->RemovePathForOrigin(
         storage::GetIdentifierFromOrigin(origin));
   }
   if (!base::DeleteFile(origin_path, true /* recursive */))
     return false;
 
   return true;
 }
 
+bool ObfuscatedFileUtil::DeleteOriginDirectoryForPluginPrivateFileSystem(
+    const GURL& origin) {
+  // Delete the plugin private filesystems from the directory database.
+  const std::string key_prefix = storage::GetIdentifierFromOrigin(origin);
+  for (DirectoryMap::iterator iter = directories_.lower_bound(key_prefix);
+       iter != directories_.end();) {
+    if (!StartsWithASCII(iter->first, key_prefix, true))
+      break;
+    SandboxDirectoryDatabase* database = iter->second;
+    directories_.erase(iter++);
+    delete database;

[xhwang, 2014/09/22 16:41:25]

If you use ScopedPtrHashMap for DirectoryMap you don't need to worry about
"delete" here:

https://code.google.com/p/chromium/codesearch#chromium/src/base/containers/sc...

[nhiroki, 2014/09/24 06:00:31]

Good idea! I'll make a separate patch to replace them.

[nhiroki, 2014/09/25 10:34:16]

I tried to replace them with ScopedPtrHashMap in
https://codereview.chromium.org/602043002/ and found we cannot use it in this
case because the hash map is not ordered and doesn't work for the prefix match.

+  }
+
+  base::File::Error error = base::File::FILE_OK;
+
+  // |origin_path| points to "/path/to/File System/Plugins/<origin>".
+  base::FilePath origin_path = GetDirectoryForOrigin(origin, false, &error);
+  if (!origin_path.empty()) {
+    if (!SandboxDirectoryDatabase::DestroyDatabase(origin_path, env_override_))
+      return false;
+    if (!base::DeleteFile(origin_path, true /* recursive */))
+      return false;
+  }
+
+  // Delete the origin directory from the origin database.
+  InitOriginDatabase(origin, false);
+  if (origin_database_) {
+    origin_database_->RemovePathForOrigin(
+        storage::GetIdentifierFromOrigin(origin));
+  }
+  return true;
+}
+
 ObfuscatedFileUtil::AbstractOriginEnumerator*
 ObfuscatedFileUtil::CreateOriginEnumerator() {
   std::vector<SandboxOriginDatabase::OriginRecord> origins;
 
   InitOriginDatabase(GURL(), false);
   return new ObfuscatedOriginEnumerator(
       origin_database_.get(), file_system_directory_);
 }
 
 bool ObfuscatedFileUtil::DestroyDirectoryDatabase(
@@ skipping 496 matching lines @@
   }
   return file.Pass();
 }
 
 bool ObfuscatedFileUtil::HasIsolatedStorage(const GURL& origin) {
   return special_storage_policy_.get() &&
       special_storage_policy_->HasIsolatedStorage(origin);
 }
 
 }  // namespace storage