Small adjustment of tracing for discarded retro frames.

Small adjustment of tracing for discarded retro frames.

Changes the trace to output to include;
 * How much the deadline was missed by.
 * The full BeginFrameArgs that was dropped.

BUG=346230
Committed: https://crrev.com/7deb2766d6b619408b86552e6bc394ce858e1790
Cr-Commit-Position: refs/heads/master@{#295631}

[mithro-old, 2014-09-18 04:24:52]

Patchset #1 (id:1) has been deleted

[mithro-old, 2014-09-18 04:27:26]

mithro@mithis.com changed reviewers:
+ brianderson@chromium.org, skyostil@chromium.org

[mithro-old, 2014-09-18 04:27:31]

Hi guys,

Another micropatch split out of https://codereview.chromium.org/267783004/

I went back and forth between wanting the trace event to including either now or
deadline (as tracing only supports two arguments without extra faffing about)
and finally went with "now - deadline" to try and capture both.

Tim 'mithro' Ansell

[mithro-old, 2014-09-18 04:34:02]

Patchset #1 (id:20001) has been deleted

[Sami, 2014-09-18 10:22:34]

lgtm with a nit.

I'm starting to wonder if some of these trace events should be moved to
disabled-by-default-cc.scheduler since this is getting a little chatty.

https://codereview.chromium.org/579083002/diff/40001/cc/scheduler/scheduler.cc
File cc/scheduler/scheduler.cc (right):

https://codereview.chromium.org/579083002/diff/40001/cc/scheduler/scheduler.c...
cc/scheduler/scheduler.cc:464: if (now < adjusted_deadline)
nit: This should be "<=" to match the previous behavior.

[brianderson, 2014-09-18 21:25:35]

lgtm2

[mithro-old, 2014-09-18 23:37:09]

The CQ bit was checked by mithro@mithis.com

[mithro-old, 2014-09-18 23:37:50]

On 2014/09/18 21:25:35, brianderson wrote:
> lgtm2

BTW a "lgtm2" doesn't seem to give you a LGTM (but Sami's LGTM should be good
enough to get this committed).

Tim

[commit-bot: I haz the power, 2014-09-18 23:39:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/579083002/60001

[commit-bot: I haz the power, 2014-09-19 01:07:57]

Committed patchset #2 (id:60001) as 6de5bd938e76c9bf773b583d947dc7ce033fce8e

[commit-bot: I haz the power, 2014-09-19 01:08:37]

Patchset 2 (id:??) landed as
https://crrev.com/7deb2766d6b619408b86552e6bc394ce858e1790
Cr-Commit-Position: refs/heads/master@{#295631}